Fix sysroot flag not passed to C build #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2020
Veykril
requested changes
Oct 19, 2020
|
Awesome, thanks a lot for looking into this! Annotated one small nitpick 😄 |
Co-authored-by: Lukas Wirth <[email protected]>
|
Thanks, TIL 😄 P.S. This is also my first PR in Rust 🎉 |
|
No need to rebase, the GH interface just appends it as a new commit onto the branch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue in #20 , caused by
sysrootpassed to bindgen but missed in theccbuild. The implementation is basically taken from bindgen too: rust-lang/rust-bindgen#1537