Adding install requirement for this package to be v14 rc3 at least#4
Merged
warrenbuckley merged 2 commits intowarrenbuckley:mainfrom May 8, 2024
Merged
Conversation
Contributor
Author
Contributor
Author
|
Turns out the other references were no longer needed, as you noted on Discord @warrenbuckley! Updated the PR. Also you already had these |
Owner
|
Thanks @nul800sebastiaan 😍 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ExaminePeek has dependencies that you would think should exclude pre-v14 installs https://github.com/warrenbuckley/Examine-Peek/blob/main/ExaminePeek/ExaminePeek.csproj#L33-L35
You can see the requirements: https://www.nuget.org/packages/ExaminePeek#dependencies-body-tab
However, since my Umbraco site doesn't have
Umbraco.Cms.Api.Common,Umbraco.Cms.Api.ManagementnorUmbraco.Cms.Web.Websitedirectly installed, the package installs into v13 without complaining. Of course the v13 site stops building after that.I found that specifying
<PackageReference Include="Umbraco.Cms" Version="14.0.0-rc3" />in the csproj file will output in the NuGet file the requirement needed, start atv14.0.0-rc3and allow installs in any version higher than that.I haven't limited it further @warrenbuckley since I would assume that this package will still work in v15 and 16.. if you want to limit it further, for example exclusively to v14 and anything under v15 then you can use
<PackageReference Include="Umbraco.Cms" Version="[14.0.0-rc3,15.0.0]" />instead. Up to you.