-
-
Notifications
You must be signed in to change notification settings - Fork 81
Permission to merge #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade jsdom from 21.1.0 to 22.1.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…579dec817252d2c [Snyk] Upgrade jsdom from 21.1.0 to 22.1.0
Snyk has created this PR to upgrade jsdom from 22.1.0 to 23.0.1. See this package in npm: See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…e168edd244de2fe [Snyk] Upgrade jsdom from 22.1.0 to 23.0.1
Snyk has created this PR to upgrade jsdom from 23.1.0 to 24.0.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…2f54092f58138fee [Snyk] Upgrade jsdom from 23.1.0 to 24.0.0
Snyk has created this PR to upgrade jsdom from 24.1.0 to 24.1.1. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…26a8678ac3308b1f [Snyk] Upgrade jsdom from 24.1.0 to 24.1.1
Snyk has created this PR to upgrade jsdom from 24.1.1 to 25.0.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade jsdom from 24.1.1 to 25.0.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…28e11c24a4d863cb [Snyk] Upgrade jsdom from 24.1.1 to 25.0.0
…b9bf727a217a23cd [Snyk] Upgrade jsdom from 24.1.1 to 25.0.0
Snyk has created this PR to upgrade jsdom from 25.0.1 to 26.0.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…a954ac1551442f8c [Snyk] Upgrade jsdom from 25.0.1 to 26.0.0
Snyk has created this PR to upgrade jsdom from 26.0.0 to 26.1.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…cddb613e8c678a59 [Snyk] Upgrade jsdom from 26.0.0 to 26.1.0
Snyk has created this PR to upgrade jsdom from 26.1.0 to 27.0.0. See this package in yarn: jsdom See this project in Snyk: https://app.snyk.io/org/visalyaputra/project/3822fafc-dbc0-4057-a4b1-a41c39243cba?utm_source=github&utm_medium=referral&page=upgrade-pr
…12b4874a6641332f [Snyk] Upgrade jsdom from 26.1.0 to 27.0.0
@Visalyputra is attempting to deploy a commit to the Waren Gonzaga's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughBumped jsdom from ^21.1.0 to ^27.0.0 in package.json. Added a new Jupyter notebook (penglab.ipynb) that conditionally installs security tools, manages wordlists, and configures selectable shell access (SSH, Python, or Bash) with mutually exclusive control flow and setup steps. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant NB as Notebook
participant FS as File System
participant Net as Network
participant Tools as Tools (hashcat/john/hydra)
participant Shell as Shell (SSH/Python/Bash)
User->>NB: Set installer flags and shell choice
NB->>NB: Validate mutually exclusive shell options
NB->>FS: Create wordlists directory (if enabled)
NB->>Net: Download selected wordlists
Net-->>NB: Archives
NB->>FS: Extract wordlists
NB->>Net: Install dependencies and build tools (per flags)
Net-->>Tools: Packages/binaries
Tools-->>NB: Installed
alt SSH selected
NB->>Shell: Configure remocolab/SSH server
else Python shell selected
NB->>Shell: Launch interactive Python loop
else Bash shell selected
NB->>Shell: Start Bash session
else No shell selected
NB->>User: Show instructions to run commands in cells
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (2)
package.json
(1 hunks)penglab.ipynb
(1 hunks)
🧰 Additional context used
🪛 Ruff (0.13.3)
penglab.ipynb
6-6: Undefined name true
(F821)
32-32: Starting a process with a shell, possible injection detected
(S605)
82-82: Starting a process with a shell: seems safe, but may be changed in the future; consider rewriting without shell
(S605)
82-82: Starting a process with a partial executable path
(S607)
85-85: Starting a process with a shell, possible injection detected
(S605)
87-87: Probable insecure usage of temporary file or directory: "/tmp/cmd"
(S108)
89-89: Probable insecure usage of temporary file or directory: "/tmp/status"
(S108)
100-100: Starting a process with a shell, possible injection detected
(S605)
102-102: Probable insecure usage of temporary file or directory: "/tmp/cmd"
(S108)
104-104: Probable insecure usage of temporary file or directory: "/tmp/status"
(S108)
I would like to ask a permission to merge. This merge is been fixed by Snyk I've fork this project and been fixing using the snyk program that I use to detect some error or improvement in the code You can check it before you allow merge just to be sure.
I want to contribute even a little to this project of yours just to improve more in the code.
I hope you read this message.
Summary by CodeRabbit