-
Notifications
You must be signed in to change notification settings - Fork 185
wardend: fix query gas limit option #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a base application option to configure query gas limit at startup by wiring Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI as CLI
participant RootCmd as cmd/wardend/cmd/root.go
participant SDKFlags as sdkserver (flags)
participant BaseApp as BaseApp
CLI->>RootCmd: start with flags
RootCmd->>SDKFlags: read FlagQueryGasLimit
SDKFlags-->>RootCmd: queryGasLimit
RootCmd->>BaseApp: include SetQueryGasLimit(queryGasLimit) in baseappOptions
RootCmd->>BaseApp: initialize application
BaseApp-->>RootCmd: app ready (configured query gas limit)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cmd/wardend/cmd/root.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: Analyze (go)
06a7866 to
8946557
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
8946557 to
3dabb4f
Compare
3dabb4f to
c844076
Compare
Same as cosmos/evm#641, we were ignoring the gas limit for queries, if set.
Closes ENG-713.