Skip to content

Conversation

@Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Oct 3, 2025

Same as cosmos/evm#641, we were ignoring the gas limit for queries, if set.

Closes ENG-713.

@Pitasi Pitasi requested a review from a team as a code owner October 3, 2025 08:16
@github-actions

This comment has been minimized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Adds a base application option to configure query gas limit at startup by wiring SetQueryGasLimit to FlagQueryGasLimit from sdkserver; adds a changelog entry documenting that app.toml's query-gas-limit was previously ignored. No other logic or error-handling changes.

Changes

Cohort / File(s) Summary
Command root option wiring
cmd/wardend/cmd/root.go
Add SetQueryGasLimit into baseappOptions, sourcing value from sdkserver's FlagQueryGasLimit so the app respects configured query gas limit at startup.
Changelog entry
CHANGELOG.md
Add Unreleased bugfix note: app.toml's query-gas-limit was being ignored; document the fix.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant CLI as CLI
    participant RootCmd as cmd/wardend/cmd/root.go
    participant SDKFlags as sdkserver (flags)
    participant BaseApp as BaseApp

    CLI->>RootCmd: start with flags
    RootCmd->>SDKFlags: read FlagQueryGasLimit
    SDKFlags-->>RootCmd: queryGasLimit
    RootCmd->>BaseApp: include SetQueryGasLimit(queryGasLimit) in baseappOptions
    RootCmd->>BaseApp: initialize application
    BaseApp-->>RootCmd: app ready (configured query gas limit)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly captures the main intent of the changeset by indicating that the query gas limit option in the wardend component is fixed, making it clear and specific without extraneous details. It references the relevant feature by name and conveys the core update so that team members scanning the history will immediately grasp its purpose. The phrasing is concise and avoids generic terms or unnecessary noise.
Description Check ✅ Passed The description clearly relates to the changeset by explaining that the gas limit for queries was previously ignored and linking to the analogous upstream fix, and it specifies the associated issue being closed. It directly addresses the behavior change introduced by the pull request and ties it to a concrete ticket, demonstrating relevance without being off-topic or overly vague.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8946557 and c844076.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • cmd/wardend/cmd/root.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8af5b2 and 06a7866.

📒 Files selected for processing (1)
  • cmd/wardend/cmd/root.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: Analyze (go)

@Pitasi Pitasi force-pushed the fix-query-gas-limit branch from 06a7866 to 8946557 Compare October 3, 2025 08:23
@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
warden-help-center Ignored Ignored Preview Oct 9, 2025 11:21am

@Pitasi Pitasi force-pushed the fix-query-gas-limit branch from 8946557 to 3dabb4f Compare October 9, 2025 11:21
@Pitasi Pitasi force-pushed the fix-query-gas-limit branch from 3dabb4f to c844076 Compare October 9, 2025 11:21
@Pitasi Pitasi merged commit 3aa55c0 into main Oct 9, 2025
13 checks passed
@Pitasi Pitasi deleted the fix-query-gas-limit branch October 9, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants