fix: return extracted values with expected formatting

wangdeer · Apr 16, 2022 · 7ece8ab · 7ece8ab
1 parent 49d324a
commit 7ece8ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/app/Containers/AppSection/Authentication/Tasks/ExtractLoginCustomAttributeTask.php b/app/Containers/AppSection/Authentication/Tasks/ExtractLoginCustomAttributeTask.php
@@ -33,8 +33,8 @@ public function run(array $data): array
         }
 
         return [
-            'username' => $loginUsername,
-            'loginAttribute' => $loginAttribute,
+            $loginUsername,
+            $loginAttribute,
         ];
     }
 

diff --git a/app/Containers/AppSection/Authentication/Tests/Unit/ExtractLoginCustomAttributeTaskTest.php b/app/Containers/AppSection/Authentication/Tests/Unit/ExtractLoginCustomAttributeTaskTest.php
@@ -27,12 +27,11 @@ public function testGivenValidLoginAttributeThenExtractUsername(): void
         $this->assertAttributeIsExtracted($result, $userDetails);
     }
 
-    private function assertAttributeIsExtracted($result, $userDetails): void
+    private function assertAttributeIsExtracted(array $result, array $userDetails): void
     {
-        $this->assertIsArray($result);
-        $this->assertArrayHasKey('username', $result);
-        $this->assertArrayHasKey('loginAttribute', $result);
-        $this->assertSame($result['username'], $userDetails['email']);
+        list($username, $loginAttribute) = $result;
+        $this->assertSame($username, $userDetails['email']);
+        $this->assertSame($loginAttribute, 'email');
     }
 
     public function testWhenNoLoginAttributeIsProvidedShouldUseEmailFieldAsDefaultFallback(): void