refactor: move tests and did some improvements

app/Containers/AppSection/User/Tests/Unit/CreateUserByCredentialsTaskTest.php

@@ -3,6 +3,7 @@
 namespace App\Containers\AppSection\User\Tests\Unit;
 
 use App\Containers\AppSection\User\Actions\RegisterUserAction;
+use App\Containers\AppSection\User\Tasks\CreateUserByCredentialsTask;
 use App\Containers\AppSection\User\Tests\TestCase;
 use App\Containers\AppSection\User\UI\API\Requests\RegisterUserRequest;
 use App\Ship\Exceptions\CreateResourceFailedException;
@@ -15,6 +16,17 @@
  */
 class CreateUserByCredentialsTaskTest extends TestCase
 {
+    public function testCreateUserByCredentials(): void
+    {
+        $data = [
+            'email' => '[email protected]',
+            'password' => 'so-secret',
+        ];
+
+        $user = app(CreateUserByCredentialsTask::class)->run($data);
+
+        $this->assertModelExists($user);
+    }
 
     public function testCreateUserWithoutEmail(): void
     {
@@ -26,8 +38,7 @@ public function testCreateUserWithoutEmail(): void
             'name' => 'Mahmoud',
         ];
 
-        $request = new RegisterUserRequest($data);
-        app(RegisterUserAction::class)->run($request);
+        app(CreateUserByCredentialsTask::class)->run($data);
     }
 
     public function testCreateUserWithoutPassword(): void
@@ -40,8 +51,7 @@ public function testCreateUserWithoutPassword(): void
             'name' => 'Mahmoud',
         ];
 
-        $request = new RegisterUserRequest($data);
-        app(RegisterUserAction::class)->run($request);
+        app(CreateUserByCredentialsTask::class)->run($data);
     }
 
     public function testCreateUserWithInvalidData(): void
@@ -55,7 +65,6 @@ public function testCreateUserWithInvalidData(): void
             'birth' => 'wrong-format',
         ];
 
-        $request = new RegisterUserRequest($data);
-        app(RegisterUserAction::class)->run($request);
+        app(CreateUserByCredentialsTask::class)->run($data);
     }
 }

app/Containers/AppSection/User/Tests/Unit/RegisterUserActionTest.php

@@ -16,19 +16,17 @@
  */
 class RegisterUserActionTest extends TestCase
 {
-    public function testCreateUser(): void
+    public function testSendNotification_AfterUserRegistration(): void
     {
         Notification::fake();
         $data = [
             'email' => '[email protected]',
             'password' => 'so-secret',
-            'name' => 'Mahmoud',
         ];
 
         $request = new RegisterUserRequest($data);
         $user = app(RegisterUserAction::class)->run($request);
 
-        $this->assertModelExists($user);
         Notification::assertSentTo($user, UserRegisteredNotification::class);
     }
 }