Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Weave Trace image to wsm #28

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

velotioaastha
Copy link
Contributor

Add the weave trace image to the wsm subcommands where all other images are used

@velotioaastha velotioaastha linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link
Contributor

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would like to get another set of eyes to confirm that we want "install": true by default.

@theishshah
Copy link
Contributor

Made PR #29 against this branch - all it does it create a second copy of the spec to manipulate for the download without keeping the changes in the spec in the bundle on disc.

@theishshah theishshah merged commit df7073a into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Weave Trace image to wsm
3 participants