Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): allow setting of extra headers for the gql client #5237

Merged
merged 6 commits into from
Apr 5, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Mar 24, 2023

Description

Provide a temporary way to pass extra headers to the GraphQL Client init.

TODO: Shall be refactored once the Settings refactor is complete.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@dmitryduev dmitryduev requested a review from a team as a code owner March 24, 2023 18:30
@github-actions github-actions bot added cc-feat and removed cc-feat labels Mar 24, 2023
Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @dmitryduev !

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #5237 (5e0f740) into main (1cdafd4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5237   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         311      311           
  Lines       38397    38400    +3     
=======================================
+ Hits        31767    31770    +3     
  Misses       6630     6630           
Flag Coverage Δ
functest 55.75% <100.00%> (+0.02%) ⬆️
unittest 73.07% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/lib/_settings_toposort_generated.py 100.00% <ø> (ø)
wandb/sdk/internal/internal_api.py 89.59% <100.00%> (-0.11%) ⬇️
wandb/sdk/internal/settings_static.py 94.93% <100.00%> (+0.06%) ⬆️
wandb/sdk/wandb_settings.py 94.33% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@raubitsj raubitsj added this to the sdk-2023-04.1 milestone Apr 4, 2023
@raubitsj raubitsj enabled auto-merge (squash) April 4, 2023 21:31
@raubitsj raubitsj changed the title feat(sdk): hacky way to set extra headers for the gql client feat(sdk): allow setting of extra headers for the gql client Apr 4, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Apr 4, 2023
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now.

@raubitsj raubitsj merged commit 2b4b259 into main Apr 5, 2023
@raubitsj raubitsj deleted the extra-http-headers branch April 5, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants