Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to pull Redis credentials from secrets in the CR #223

Conversation

velotioaastha
Copy link
Contributor

@velotioaastha velotioaastha commented Sep 23, 2024

Added support to pull REDIS entire configuration from secrets from Secrets when deploying CRD from yaml file.
Secret should look like this :

kind: Secret
metadata:
  name: my-redis-secret
type: Opaque
data:
  REDIS_PASSWORD: bXlwYXNzd29yZA==   
  REDIS_CA_CERT: bXljYQ== 
  REDIS_PORT: NjM3OQ==
  REDIS_HOST: bXlyaWRpcy5leGFtcGxlLmNvbQ==

Copy link
Contributor

@danielpanzella danielpanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some other thoughts, but I need to get some additional context from @jsbroks as to why we provide the redis creds as both a single connection string and multiple fields, and more imporant, what does the application actually use.

charts/operator-wandb/templates/_redis.tpl Show resolved Hide resolved
charts/operator-wandb/templates/_redis.tpl Show resolved Hide resolved
@danielpanzella
Copy link
Contributor

@velotioaastha The only way I could figure out how I wanted this implemented was to implement it myself. See #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants