-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use best practices for wandb.init() and the Run object #1146
Conversation
Deploying docs with
|
Latest commit: |
356c22e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://cd87887d.docodile.pages.dev |
Branch Preview URL: | https://timoffex-avoid-global-run.docodile.pages.dev |
c2165da
to
59c5cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a copyedit pass to try to help out. I think @ngrayluna should take a look at the technical changes and may have other feedback. Thanks!
Co-authored-by: Matt Linville <[email protected]>
e42eb01
to
737642b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small suggestions for the copy in case they are helpful. I am not sure whether @ngrayluna wants to take another look before we merge?
Nice. Thanks so much @timoffex! |
Ticket for tracking other code blocks that need updating: https://wandb.atlassian.net/browse/DOCS-1336 |
wandb.run
) or implicitly (wandb.config
,wandb.log
, etc.) to use a Run object directly instead.wandb.init()
as a context manager by default. This is a best practice from the SDK's perspective because it avoids dangling runs: when thewith
block exits, the run is marked complete (on normal exit) or failed (on exception) and the process waits for its data to finish uploading.This regex finds most places that need to be updated (with some false positives):
Unfortunately, there are quite a few places left to update---523 by my count! This PR just updates some top-level guides for users and integrations, which I think are the most important places to start with.