Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing arches to cross-compilation #120

Closed
wants to merge 4 commits into from
Closed

Add missing arches to cross-compilation #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ddaf7f
Add missing arches to cross-compilation
ctrlcctrlv Jan 21, 2023
14d4b4d
fuck it this is too complicated lol
ctrlcctrlv Jan 21, 2023
393059d
Drop macOS per maintainer comment
ctrlcctrlv Jan 24, 2023
95fff35
Remove shebang line from arches.sh
ctrlcctrlv Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions arches.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Not intended to be run directly.
echo " Linux i386..."
GOOS=linux GOARCH=386 ./build.sh
echo " Linux amd64..."
GOOS=linux GOARCH=amd64 ./build.sh
echo " Linux arm..."
GOOS=linux GOARCH=arm64 ./build.sh
echo " Linux arm64..."
GOOS=linux GOARCH=arm64 ./build.sh
echo " Windows 386..."
GOOS=windows GOARCH=386 ./build.sh
Comment on lines +10 to +11
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anybody running Windows 386?

If not I'd prefer not supplying binaries for it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have heard it tends to be lighter weight in virtual machines and most projects I work on continue to support it but I don't mind dropping the line.

echo " Windows amd64..."
GOOS=windows GOARCH=amd64 ./build.sh
5 changes: 1 addition & 4 deletions release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ git tag --annotate "${VERSION}"
# NOTE: To get the version number right, these builds must be done after the
# above tagging.
#
# NOTE: Make sure this list matches the one in test.sh
GOOS=linux GOARCH=386 ./build.sh
GOOS=darwin GOARCH=amd64 ./build.sh
GOOS=windows GOARCH=amd64 ./build.sh
source arches.sh

# Push the newly built release tag
git push --tags
Expand Down
8 changes: 1 addition & 7 deletions test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,8 @@ echo "Running unit tests..."
go test -timeout 20s ./...

# Ensure we can cross compile
# NOTE: Make sure this list matches the one in release.sh
echo "Testing cross compilation..."
echo " Linux i386..."
GOOS=linux GOARCH=386 ./build.sh
echo " macOS amd64..."
GOOS=darwin GOARCH=amd64 ./build.sh
echo " Windows amd64..."
GOOS=windows GOARCH=amd64 ./build.sh
source arches.sh

# Verify sending the output to a file
RESULT="$(mktemp)"
Expand Down