Add configurable theme workaround for Onyx Boox devices #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a lot of potentially conflicting pending changes, so I guess I'll have to reintegrate this after #931. |
|
I'm happy to rebase and fix conflicts after that's in master, if needed. |
|
Rebased now that #931 was merged! |
|
I added some corrections here. Can you merge/cherry-pick it into your branch and test that it still works? |
|
Pushed, thanks for the follow-up! Still seems to work fine. |
tcitworld
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #168 (comment)
Note that I'm not too familiar with Android development - I added all the XML stuff by hand, so it'd be good if someone could double-check that I didn't miss anything.