-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve link styling for high-contrast theme #885
Conversation
Looking at #84, the high-contrast theme originally was created for eReader devices. On my device (an Onyx Boox Nova Pro), it works quite well, but both links (being a rather dark blue) and normal text get rendered as black, making it impossible to tell them apart from normal text. This change makes links black and re-adds the underlining.
We currently have a high-contrast and an "e-ink" theme, which only differ in that the "e-ink" one has If so, I would suggest to simply rename Update: Now I can see you suggested renaming |
Yeah, I wasn't sure about it - not sure who would use the high contrast theme without an e-ink device. If we're thinking of e.g. people with bad vision, I guess it'd make sense to have the link text in black (to have a high contrast) as well. Some related discussions:
Also pinging @tenkabuto I personally don't care much either way - let me know how to proceed and I will 😉 |
I agree with suggestions from @di72nn. Let's at least make the |
I'm using the e-ink theme right now on an inkbook prime and can tell apart links from text just fine. Links are light-grey, text is black. |
Hmm, okay, seems like this is only needed for Onyx devices then. After thinking about it some more, I'd propose this:
How does that sound? Closing this in the meantime. I'll try to follow up with new PRs for these, but it might take a while, as I have quite a bit on my plate right now. |
Looking at #84, the high-contrast theme originally was created for eReader
devices.
On my device (an Onyx Boox Nova Pro), it works quite well, but both links (being
a rather dark blue) and normal text get rendered as black, making it impossible
to tell them apart from normal text.
This change makes links black and re-adds the underlining.
cc @shtrom