Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-wrap Lines by default, setting to change to overflow #812

Merged
merged 3 commits into from
Aug 26, 2019
Merged

Pre-wrap Lines by default, setting to change to overflow #812

merged 3 commits into from
Aug 26, 2019

Conversation

NWuensche
Copy link
Contributor

Fix one of the requests in #734 .

@NWuensche NWuensche force-pushed the handleLongLines branch 2 times, most recently from ca4b150 to cde9bb2 Compare August 25, 2019 12:33
@NWuensche
Copy link
Contributor Author

Of course, I will squash everything again once this PR is approved.

tcitworld
tcitworld requested changes Aug 25, 2019
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make overflow and pre-wrap translatable (and more explained) because not all users know what this mean.

@di72nn
Copy link
Member

di72nn commented Aug 25, 2019

Maybe also make it clear that the option is for preformatted text (code blocks, etc.), rather then any long lines.

@NWuensche NWuensche force-pushed the handleLongLines branch 4 times, most recently from 503f7e2 to 8c7f955 Compare August 25, 2019 19:04
@NWuensche
Copy link
Contributor Author

NWuensche commented Aug 25, 2019 •
edited
Loading

Thanks, I hope everything is ready now.

@NWuensche NWuensche force-pushed the handleLongLines branch 2 times, most recently from 8c7abb9 to 4daa817 Compare August 26, 2019 06:15
@NWuensche NWuensche requested review from tcitworld and di72nn August 26, 2019 06:30
@NWuensche NWuensche requested a review from di72nn August 26, 2019 09:45
@tcitworld tcitworld merged commit 72c47ed into wallabag:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@di72nn di72nn Awaiting requested review from di72nn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NWuensche @di72nn @tcitworld