Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AndroidX #803

Closed
wants to merge 14 commits into from
Closed

Migrate to AndroidX #803

wants to merge 14 commits into from

Conversation

msfjarvis
Copy link

This PR also upgrades dependencies and rewrites the Travis-CI configuration for faster builds

dependabot-preview bot and others added 12 commits August 15, 2019 08:46
Bumps slf4j-android from 1.7.25 to 1.7.28.

Signed-off-by: dependabot-preview[bot] <[email protected]>
Signed-off-by: Harsh Shandilya <[email protected]>
Signed-off-by: Harsh Shandilya <[email protected]>
Signed-off-by: Harsh Shandilya <[email protected]>
@di72nn
Copy link
Member

di72nn commented Aug 15, 2019

Cool, thanks!
I'll try to review it soon.

@di72nn di72nn self-requested a review August 15, 2019 11:54
@msfjarvis
Copy link
Author

Cool, thanks!
I'll try to review it soon.

Awesome! Once this lands I'll start bringing in some UI improvements :)

P.S. A file like this will automatically handle review requests for you.

Copy link
Member

@di72nn di72nn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tcitworld @Strubbl wanna check it out?

@di72nn
Copy link
Member

di72nn commented Aug 16, 2019

Once this lands I'll start bringing in some UI improvements :)

That'd be great!

P.S. A file like this will automatically handle review requests for you.

Thanks for the tip, I'll keep it in mind.

msfjarvis and others added 2 commits August 23, 2019 01:23
* origin/master:
  Version 2.2.4
  Show nice notification when adding entry without connected server
  Fix initial sort order of articles

Signed-off-by: Harsh Shandilya <[email protected]>
Bumps gradle from 3.4.2 to 3.5.0.

Signed-off-by: dependabot-preview[bot] <[email protected]>
Signed-off-by: Harsh Shandilya <[email protected]>
Copy link
Contributor

@Strubbl Strubbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcitworld tcitworld mentioned this pull request Aug 25, 2019
tcitworld added a commit that referenced this pull request Aug 25, 2019
This PR also upgrades dependencies and rewrites the Travis-CI configuration for faster builds

See #803
@tcitworld
Copy link
Member

Merged in #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants