[WIP] Automatic Update when opening app #404
Conversation
| @@ -447,6 +448,7 @@ private ArticlesListFragment getFragment(int position) { | |||
| private void syncQueue() { | |||
| if(!WallabagConnection.isNetworkAvailable()) { | |||
| Toast.makeText(this, getString(R.string.txtNetOffline), Toast.LENGTH_SHORT).show(); | |||
| Toast.makeText(this, getString(R.string.prevLoad), Toast.LENGTH_SHORT).show(); | |||
There was a problem hiding this comment.
Does is it make sense to have two toasts in a row?
There was a problem hiding this comment.
Well, it can be concatenated to form one. But if we remove the second one, it would seem as if it is a bug in the app if it always pop up during the start of the app
|
I do not want to have automatic update of article list on opening up the app due to high mobile traffice when loading the images. I would only accept it on WIFI only. |
|
You see that can be moderated as a check if the device is connected to wifi or not. |
| @@ -73,6 +73,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| setContentView(R.layout.activity_articles_list); | |||
|
|
|||
| settings = new Settings(this); | |||
| syncQueue(); | |||
There was a problem hiding this comment.
That's not what you think it is. It launches offline queue sync (the sync of the changes that were not synced to server when there were no data connection).
|
First of all, thanks for your contribution. Here's my opinion regarding that feature:
|
|
Thank you for your response. |
tcitworld
changed the title
|
The feature was implemented in #370 (except for "only on Wi-Fi" part). Thanks for your work anyway. |
|
@di72nn Is there a need for a new issue for the "only on Wi-Fi" part? |
|
oh, ok. forgot about it. |
The app is automatically updated when it starts. In case there is no internet, a message is shown informing that there is no net connection, so the previous list is being loaded.
This is in response to issue no #360