Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap-to-scroll option #299

Merged
merged 4 commits into from
Oct 13, 2016
Merged

Add tap-to-scroll option #299

merged 4 commits into from
Oct 13, 2016

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Sep 20, 2016

#168.

Replaces #266.

Same note applies:

The "sides" are limited by:

  • height: (0.25; 0.75) scrollView's height;
  • width: left is [0; 0.3) of scrollView's width and right is (0.7; 1].

For some reason touch events are not consumed: if you tap on a link it will both scroll and open link menu.

@di72nn
Copy link
Member Author

di72nn commented Oct 3, 2016

Is there any problem with it?
I got the impression that the feature would be very useful for E-Ink users, but would not affect anyone who does not enable it. The implementation is somewhat poor (no UI buttons (are they needed?) and the event consumption issue (nothing serious)), but it is better than nothing.

P. S.: Now that I think about it, maybe I should also add "scroll with volume buttons" option or something like that.

@Strubbl
Copy link
Contributor

Strubbl commented Oct 3, 2016

Sorry, i am not interested in this feature at all. That's why i did not review yet.

The scroll with volume buttons option might be interesting for users without e-ink display, too.

@tcitworld
Copy link
Member

@di72nn This would be great !

P. S.: Now that I think about it, maybe I should also add "scroll with volume buttons" option or something like that.

@di72nn
Copy link
Member Author

di72nn commented Oct 3, 2016

Added an option to scroll with volume buttons. Also added a "smooth scrolling" checkbox. Is it just me, or smooth scrolling with volume buttons is not always smooth (maybe threading issue or something else)?

@Strubbl Strubbl merged commit dc39fbe into master Oct 13, 2016
@Strubbl Strubbl deleted the touch_scroll branch October 13, 2016 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants