Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-factor authentication (2FA) support #359

Open
di72nn opened this issue Nov 30, 2016 · 8 comments
Open

Two-factor authentication (2FA) support #359

di72nn opened this issue Nov 30, 2016 · 8 comments
Labels
depends on wallabag server dependent on changes in wallabag server software Improvement

Comments

@di72nn
Copy link
Member

di72nn commented Nov 30, 2016

The app does not support 2FA (not relevant for wallabag v1.9).

Also maybe add a notice somewhere about 2FA not being supported in the meantime.

@anarcat
Copy link

anarcat commented Nov 30, 2016

note that this is related to a bunch of other issues. #203, as mentionned, but also #291 and #292.

symptoms of this problem include "Wallabag service not found" errors and receiving a 2FA code when trying to login through the app.

@Strubbl
Copy link
Contributor

Strubbl commented Nov 30, 2016

There is a hint in the documentation w.r.t. missing 2fa: http://doc.wallabag.org/en/master/user/android.html#two-factor-authentication-2fa

@axilleas
Copy link

I just bumped into this, it would be cool to support. A better error message would be helpful too :)

Strubbl added a commit that referenced this issue Jan 11, 2018
until #359 is implemented, the user gets a concretized error message.
@ChrisCarini
Copy link

Hey @di72nn & @Strubbl, in 2019, what are the plans for 2FA support in the Android application? Is there anything particular blocking this feature/improvement being added?

@di72nn
Copy link
Member Author

di72nn commented Mar 29, 2019

The thing is the app currently uses two ways to communicate with the server:

  • It makes HTTP requests and parses HTML responses to log into wallabag and to generate API credentials. This part is protected with 2FA.
  • After that the app uses the API credentials to actually function. This is not affected by 2FA.

Implementing 2FA support would require to further complicate the first part. The problem is that the app shouldn't be doing that part at all: there should be a different way of getting API credentials. So implementing 2FA at this point would be like creating a crutch for a crutch.

My memory is somewhat hazy on the matter, but as a workaround one probably can disable 2FA for the first setup, then after confirming that the app functions ok, enable 2FA again.

@ChrisCarini
Copy link

Hey @di72nn ,

Thanks for the detailed response - this makes a lot of sense. A secondary thought then; would it be possible for the app to instead prompt for API credentials (that the user can create via the web UI)? It may not be as great of an experience compared to simply logging in and entering the 2FA, but it might be a good-ish middle ground for the time being.

In the mean time, your workaround worked great for me! Thank you! The app is great! :)

Best,
Chris

@tasmo
Copy link

tasmo commented Jul 15, 2024

In the first start wizard is no way to set up with client ID and secret. i always get an error.

@di72nn
Copy link
Member Author

di72nn commented Jul 15, 2024

@tasmo you don't need to go through the wizard - just leave it (by pressing "back" or "skip") and manually set up the credentials in settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on wallabag server dependent on changes in wallabag server software Improvement
Projects
None yet
Development

No branches or pull requests

6 participants