Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace httr::GET() with httr:RETRY() #91

Closed
wants to merge 1 commit into from
Closed

replace httr::GET() with httr:RETRY() #91

wants to merge 1 commit into from

Conversation

annnvv
Copy link

@annnvv annnvv commented Apr 19, 2020

Thanks for this awesome project @walkerke!

In this PR, I'd like to propose swapping out calls to httr::GET() etc. with httr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic almost always improves the user experience with HTTP clients.

I'm working on chircollab/chircollab20#1 as part of Chicago R Collab, an R 'unconference' in Chicago.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@walkerke
Copy link
Owner

walkerke commented Jul 9, 2020

Thank you for your PR! I've tested this out, and tigris already implements equivalent functionality using a while() loop with a custom message. This PR supercedes that with a less informative message so I'm not going to merge. Appreciate it regardless, however!

@walkerke walkerke closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants