docs: Cloudflare guide update with example #943
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
examples/26_cloudflare/package.json
Outdated
| "hono": "^4.6.3", | ||
| "react": "19.0.0-rc-2d16326d-20240930", | ||
| "react-dom": "19.0.0-rc-2d16326d-20240930", | ||
| "react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930", | ||
| "waku": "0.21.3", | ||
| "wrangler": "^3.80.0" |
There was a problem hiding this comment.
we pin versions.
| "hono": "^4.6.3", | |
| "react": "19.0.0-rc-2d16326d-20240930", | |
| "react-dom": "19.0.0-rc-2d16326d-20240930", | |
| "react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930", | |
| "waku": "0.21.3", | |
| "wrangler": "^3.80.0" | |
| "hono": "4.6.3", | |
| "react": "19.0.0-rc-2d16326d-20240930", | |
| "react-dom": "19.0.0-rc-2d16326d-20240930", | |
| "react-server-dom-webpack": "19.0.0-rc-2d16326d-20240930", | |
| "waku": "0.21.3", | |
| "wrangler": "3.80.0" |
|
Thank you. I will make these updates after I fix #944. Switching to draft for now. |
rmarscher
force-pushed
the
docs/cloudflare-example
branch
2 times, most recently
from
7ab9ab3 to
23f15ee
Compare
|
I think this should be ready once #989 is merged. |
examples/44_cloudflare/package.json
Outdated
| }, | ||
| "prettier": { | ||
| "singleQuote": true |
There was a problem hiding this comment.
| }, | |
| "prettier": { | |
| "singleQuote": true |
examples/44_cloudflare/package.json
Outdated
| "react": "19.0.0-rc-bf7e210c-20241017", | ||
| "react-dom": "19.0.0-rc-bf7e210c-20241017", | ||
| "react-server-dom-webpack": "19.0.0-rc-bf7e210c-20241017", | ||
| "waku": "0.21.5", |
There was a problem hiding this comment.
This is updated. Check the main branch.
There was a problem hiding this comment.
This is updated. Check the main branch.
OK. All set. I rebased the branch. This is ready for review.
There was a problem hiding this comment.
Prettier error... one moment...
There was a problem hiding this comment.
New error error TS2688: Cannot find type definition file for './.wrangler/types/runtime.d.ts'. 🙄 I'll look for a workaround.
rmarscher
force-pushed
the
docs/cloudflare-example
branch
2 times, most recently
from
37b4db5 to
214d09a
Compare
rmarscher
force-pushed
the
docs/cloudflare-example
branch
from
214d09a to
358b14c
Compare
Workaround React Portal children type error in 19.0.0-rc.1
|
It looks like running the example for E2E is hitting a 401 Unauthorized error. I guess running the miniflare dev server communicates with Cloudflare's API and is expecting CLOUDFLARE_API_TOKEN and CLOUDFLARE_ACCOUNT_ID to be set in the environment. |
|
I tried a couple workarounds. I need to set up a copy of the CI environment so I can figure out how to workaround the authorization error. I think adding actual CLOUDFLARE_API_TOKEN and CLOUDFLARE_ACCOUNT_ID secrets to the GitHub CI environment would also fix it. |
|
I don't think it's a CI issue, but I can't run the test without those envvars, right? Doesn't it need a mock auth server? |
|
I think the authorization error that I saw in the CI logs was unrelated. I had an error from updating to the latest minimal client. I'm guessing that it was working locally for me because I had cached vite assets or something like that. |
Moving a code example for Cloudflare to Waku so we don't need to reference my public gist and it's easier for everyone to test.