Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server context #86

Merged
merged 19 commits into from
Jul 6, 2023
Merged

feat: server context #86

merged 19 commits into from
Jul 6, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jun 27, 2023

(It's different from React Server Context.)

It's to communicate with req and res.

Close #54

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 2:15am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05d6979:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

@dai-shi dai-shi mentioned this pull request Jun 20, 2023
Comment on lines 19 to 20
prehook?: (req: IncomingMessage) => Context;
posthook?: (res: ServerResponse, ctx: Context) => void;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestion for naming these?

@dai-shi
Copy link
Member Author

dai-shi commented Jul 5, 2023

It's kind of WIP and we have some hacks, which should be fixed later.
But, merging it anyway to collect some feedbacks.

@dai-shi dai-shi marked this pull request as ready for review July 5, 2023 08:44
@dai-shi dai-shi merged commit f768a56 into main Jul 6, 2023
@dai-shi dai-shi deleted the feat/server-context branch July 6, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support reading request "context" in server actions
1 participant