fix(create-waku): Fix detection of bun using npm_config_user_agent env var #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that running
bun create waku@latestandbunx create-waku@latestdidn't seem to detectbunas the package manager as expected based on my changes in #1229.However - I was able to verify that both formats should work when I tested with a new dummy package:
create-debug-createbun create debug-create@latest # and bunx create-debug-create@latestwill print some things to the console (e.g.
process.env,process, etc).Based on running both of those - it seems like the
npm_config_user_agentenv var does get populated withbunas expected (not sure how I was testing before where it didn't work - maybe just with running the CLI directly viabun ./cli.mjs?)