Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): static route handling #1194

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix(router): static route handling #1194

merged 2 commits into from
Jan 28, 2025

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 27, 2025

There was a bug that skip didn't work for rootElement and routeElement. This also does some refactors.

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 28, 2025 0:28am

Copy link

codesandbox-ci bot commented Jan 27, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Jan 27, 2025
@dai-shi dai-shi marked this pull request as ready for review January 27, 2025 15:21
Copy link
Member

@tylersayshi tylersayshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@dai-shi dai-shi merged commit ea21e74 into main Jan 28, 2025
26 checks passed
@dai-shi dai-shi deleted the fix/router/static-routes branch January 28, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants