- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): add website to smoke tests & fix dev server error #1095
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
'react-server-dom-webpack/client', | ||
'react-server-dom-webpack/client.edge', | ||
'react-dom/client', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not seem to work. not sure if I am putting this in the correct spot yet
packages/website/vite.config.ts
Outdated
include: ['next-mdx-remote/rsc'], | ||
include: [ | ||
'next-mdx-remote/rsc', | ||
'react-server-dom-webpack/client.edge', // FIXME this should be managed by dev-server-impl.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this solves the bug, but I know we should manage this internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!!
the error: