Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travisci to github actions #19

Merged
merged 1 commit into from
Jun 1, 2022
Merged

travisci to github actions #19

merged 1 commit into from
Jun 1, 2022

Conversation

waka
Copy link
Owner

@waka waka commented May 31, 2022

Stop Travis CI and move to GitHub Actions

@waka waka force-pushed the travisci2github_actions branch from 3ef25de to 8f4905f Compare June 1, 2022 05:36
spec.add_development_dependency 'pry'
spec.add_development_dependency 'minitest'
spec.add_development_dependency 'erubis'
spec.add_development_dependency 'mysql2', '>= 0.4.4', '< 0.6.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image: mysql:5.7
env:
MYSQL_ALLOW_EMPTY_PASSWORD: yes
MYSQL_DATABASE: 'activerecord_unittest'
Copy link
Contributor

@keik keik Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This database is required to create in local environment testings, and this is a little bit implicit.
I think that It is better to write doc or make script to do this.

Copy link
Contributor

@keik keik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
nice~~

@waka
Copy link
Owner Author

waka commented Jun 1, 2022

arigato!

@waka waka merged commit e99ab3a into master Jun 1, 2022
@waka waka deleted the travisci2github_actions branch June 1, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants