fix(cli): install the engine on the daemon path without a browser wizard (waired#835 §11)

[gen16k]

The bug this fixes exists today, on macOS

#115 gave the daemon path an executor-driven engine install, but gated it on setupActive — a browser wizard actually driving. I scoped that too narrowly. Every terminal-only daemon-path install still finishes with no engine: --non-interactive, --no-browser, no TTY, pressing Enter to take the terminal back, or simply not touching the browser.

And that is not a future problem waiting on the §11.2 ordering flip. macOS already takes the daemon path on its default install:

# packaging/install/install.sh  darwin_install
darwin_register_agent "$state_dir"     # :1150 — launchctl bootstrap
darwin_install_log_rotation            # :1151
darwin_write_control_url "$state_dir"  # :1152
darwin_maybe_init "$state_dir"         # :1153 ← init runs HERE

darwin_register_agent runs waired-agent install, whose plist sets RunAtLoad=true — service_darwin.go's own comment says "the agent starts the moment launchctl bootstrap finishes". So the daemon is up before init runs, daemonReachable is true, and init takes runInitViaDaemon. The installer also stopped pre-installing the engine (install.sh:1143-1148).

Net: the default macOS install has been completing with no engine, while darwin_next_steps prints installed by sign-in when local inference is on (sudo waired init) — the opposite of what happens.

installtest cannot see this. Every enroll leg forces the standalone branch — --bypass-mode, --google-sa-login, or an explicit service stop — so main.go:325's !*googleSALogin guard means the daemon path has never been exercised by installtest at all. That coverage gap is what hid it.

Evidence level: verified by reading the code path end to end. Not reproduced on a real macOS host — I don't have one here.

Changes

ensureDaemonPathEngine — install when the host wants inference, not when a wizard is driving. The condition is read from the daemon's own inference subsystem state rather than from any flag, so it reflects what the agent actually decided:

subsystem_state	action	why
no_engine	install	inference is on and there is nothing to serve with
disabled / stopped	skip	deliberate operator states
anything else	skip	an engine already exists
unreachable until engineWaitForStatus	skip	never install on a guess

installEngineAsExecutor — extracted from the wizard path so both entry points share one claim → decide → install → report core. Only the narration differs; saying "for the setup in your browser" during a terminal-only install is confusing.

SetupState now serves state_dir unconditionally. #115 served it only alongside a desired engine, with the comment "there is nothing to install otherwise". That reasoning is precisely what this PR falsifies — a no-wizard install has no desired engine and still needs the destination. Withholding it is what would keep the install engine-less.

applyDaemonInitInference — re-apply --inference-enabled, --share-with-mesh and --inference-bundled-model-id after a daemon-path login. LoginStartRequest carries only a control URL and a device name, so these three have been accepted and silently dropped; install.ps1:1372-1373 has been passing --inference-enabled on Windows to no effect (§11.2). Applied via the management routes that already own these controls — no new wire.

• nil means "not passed", so absence never overwrites what the host already decided.
• A model is not requested on a host that just turned inference off (that would be a multi-GB download nobody can use).
• Every failure warns; login already succeeded and a knob that did not apply must not fail the install.

Ordering is load-bearing. Flags are re-applied before awaitBrowserSetup (nothing races desired_model_id, per §4.2) and before waitForBundledModel (the terminal must not wait on a download the operator asked to skip, nor download the auto-selected model and only then switch).

Tests

New (init_daemon_inference_test.go): a 6-case table over flag re-application including "nothing passed touches nothing" and "model skipped when inference turned off"; failure-tolerance; a 5-state table for the engine decision; the give-up path against an unreachable daemon; the no-wizard install happy path; and a 6-case skip table (disabled / stopped / engine present / no state dir / wizard already claimed / older daemon).

daemonPathEngineInstall takes goos/elevated as parameters per the repo's cross-OS rule, so the install arm is reachable from an unprivileged runner.

Updated: TestSetupStateOmitsStateDirWithoutDesiredEngine → TestSetupStatePublishesStateDirWithoutDesiredEngine. It pinned the assumption this PR overturns, and I rewrote its comment to say why rather than just flipping the assertion.

Verification

gofmt -l .          # clean
go vet ./...        # clean
golangci-lint run   # 0 issues
go test ./... -timeout 10m   # all pass
make verify-cross   # 4 GOOS/GOARCH combinations clean

Not verified: a real macOS install, and the actual engine download (a ~GB fetch behind an elevation gate). The installer seam is the same installOllama that has shipped on the interactive path.

Still uncovered, deliberately: installtest has no daemon-path enroll leg. Adding one needs a login mode that reaches runInitViaDaemon, which today means relaxing the !*googleSALogin guard or driving a browser login. That belongs with the ordering flip (PR-R2), where the daemon path becomes the default and the gap becomes urgent.

Refs

• Refs waired-ai/waired#835 (§11 / §11.2)
• Spec side: waired-ai/waired#876 records the macOS correction and the split
• Follows feat(cli): install the engine as the setup executor on the daemon path (waired#835 §11) #115; blocks the §11.2 installer ordering flip (PR-R2)

🤖 Generated with Claude Code