Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2, windows] Unlock OSThread after native calls have been finished #1441

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Jun 8, 2022

This makes sure the OSThread can be reused by other go
routines after a native call has been finished. Otherwise the
OSThread will be destroyed as soon as the goroutine has
finished.

Form.Invoke makes sure the call is on the correct thread and does
lock the OSThread during the call.
This makes sure the OSThread can be reused by other go
routines after a native call has been finished. Otherwise the
OSThread will be destroyed as soon as the goroutine has
finished.
@stffabi stffabi enabled auto-merge (squash) June 8, 2022 06:29
@leaanthony
Copy link
Member

Nice one!

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stffabi stffabi merged commit 664f6a9 into wailsapp:master Jun 8, 2022
@stffabi stffabi deleted the feature/windows-unlockosthread branch June 8, 2022 13:23
@stffabi
Copy link
Collaborator Author

stffabi commented Jun 8, 2022

Thanks for approving.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants