Skip to content

fix sed escaping #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2023
Merged

fix sed escaping #239

merged 1 commit into from
Sep 17, 2023

Conversation

divyam234
Copy link
Contributor

Encrypted password are not escaped properly in caddy this work for all cases

@wahyd4
Copy link
Owner

wahyd4 commented Sep 15, 2023

Hi @divyam234 can you provide any examples that the current command will fail while your one would work?

@divyam234
Copy link
Contributor Author

divyam234 commented Sep 15, 2023 •
edited
Loading

@wahyd4 when caddy hash password includes $ and / in it i current sed command fails

like this for example $2a$14$Zkx19XLiW6VYouLHR5NmfOFU0z2GTNmpkT/5qqR7hx4IjWJPDhjvG

wahyd4
wahyd4 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@wahyd4 wahyd4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wahyd4 wahyd4 merged commit 6c3caac into wahyd4:master Sep 17, 2023
@wahyd4
Copy link
Owner

wahyd4 commented Sep 17, 2023

Hi @divyam234,thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wahyd4 wahyd4 wahyd4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyam234 @wahyd4