Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker setup for wagtail guide #239

Conversation

VictoriaAjala
Copy link
Contributor

This PR fixes issues I encountered when setting up wagtail with docker.

Without installing the necessary dependency with

RUN apt-get install -y gettext 

the make docker-init step fails with the error below:
Screenshot from 2022-10-30 00-16-28

@VictoriaAjala
Copy link
Contributor Author

@lb- @thibaudcolas

@lb-
Copy link
Member

lb- commented Oct 30, 2022

I do not use docker, so I am not the best to review this - but I am sure someone in the team will see this and give feedback when available.

@saevarom
Copy link
Contributor

I'd prefer not messing with the Heroku Dockerfile since that is used for deployments.
There is another PR #221 which defines a separate Dockerfile for local development and there we could add suport for gettext in the container.

So I would recommend merging #221 first and then think about supporting gettext in the local docker container. It would probably make the most sense to close this PR and create a new one after #221 is merged.

@VictoriaAjala
Copy link
Contributor Author

Alright @saevarom, sounds good.

Closing this and creating a new PR when #221 has been merged.

@thibaudcolas thibaudcolas added the Outreachy https://www.outreachy.org/ label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Outreachy https://www.outreachy.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants