fix runtime error #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +171,7 @@ func reload_labels(): | |||
|
|
|||
|
|
|||
| func reload_button(button, translation, label_node_name="Label"): | |||
| if button: | |||
| if button and button.has_node(label_node_name): | |||
There was a problem hiding this comment.
Interesting, this error would indicate we still have old style button+label code somewhere - new buttons have integrated labels. It probably should apply reload_label() directly to button on else.
|
I haven't found the time to add czlowiekimadlo's suggestion. Anybody else who stumbles across this is welcome to finish it. |
czlowiekimadlo
pushed a commit
that referenced
this pull request
Jan 10, 2019
|
Since the change was small I have ported it manually with suggested change. Thank you very much for help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just resolves some errors that are output on stdout when the game runs.