Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正素材管理中的返回值文档注释,正确的类型应该是集合,而不是字符串。 #695

Merged
merged 1 commit into from
May 11, 2017

Conversation

starlight36
Copy link
Contributor

被坑了,直接取返回值以为是media_id,其实是个集合对象。建议在文档里面也详细描述一下返回值。

@overtrue overtrue merged commit e39472d into w7corp:develop May 11, 2017
@overtrue
Copy link
Collaborator

🤣

@overtrue
Copy link
Collaborator

@starlight36 starlight36 deleted the fix-comment-doc branch May 11, 2017 12:11
@starlight36
Copy link
Contributor Author

我直接进这个了,并没有写返回值 😂 https://easywechat.org/zh-cn/docs/material.html#临时素材-API

@overtrue
Copy link
Collaborator

@starlight36 我的锅 😆

never615 added a commit to never615/wechat that referenced this pull request May 19, 2017
* 'develop' of github.com:overtrue/wechat: (56 commits)
  Rename method. (w7corp#699)
  Apply fixes from StyleCI (w7corp#698)
  Tweak open-platform code.
  add return types.
  修正素材管理中的返回值文档注释,正确的类型应该是集合,而不是字符串。 (w7corp#695)
  Add official-account core service provider.
  Apply fixes from StyleCI (w7corp#684)
  separate open-platform service providers.
  Apply fixes from StyleCI (w7corp#683)
  Sorted class.
  cleanup open-platform class.
  Remove old files.
  separate mini-program service providers.
  Apply fixes from StyleCI (w7corp#682)
  Move `AbstractAPI` class.
  Apply fixes from StyleCI (w7corp#681)
  Move `Http` class.
  Apply fixes from StyleCI (w7corp#680)
  Minimum PHP version.
  add test.
  ...

# Conflicts:
#	composer.json
#	src/Foundation/Application.php
#	src/OpenPlatform/ServiceProvider.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants