-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ring mgmt in Lagrangian basis #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
burdges
approved these changes
Nov 8, 2023
burdges
reviewed
Nov 15, 2023
@@ -17,18 +17,22 @@ pub struct PiopParams<F: PrimeField, Curve: SWCurveConfig<BaseField=F>> { | |||
pub(crate) scalar_bitlen: usize, | |||
|
|||
// Length of the part of the column representing the public keys (including the padding). | |||
pub keyset_part_size: usize, | |||
pub(crate) keyset_part_size: usize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This maybe a problem
burdges
pushed a commit
to w3f/ring-vrf
that referenced
this pull request
Nov 15, 2023
burdges
pushed a commit
to w3f/ring-vrf
that referenced
this pull request
Nov 16, 2023
burdges
pushed a commit
to w3f/ring-vrf
that referenced
this pull request
Nov 21, 2023
@swasilyev @burdges looks like this allows to reduce the size of the serialized stuff by a 3x? Is possible to leverage this optimization in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.