Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring mgmt in Lagrangian basis #13

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Ring mgmt in Lagrangian basis #13

merged 12 commits into from
Nov 9, 2023

Conversation

swasilyev
Copy link
Collaborator

No description provided.

@swasilyev swasilyev marked this pull request as ready for review November 6, 2023 15:05
@burdges
Copy link
Collaborator

burdges commented Nov 8, 2023

LGTM

@swasilyev swasilyev merged commit 7275eb6 into master Nov 9, 2023
1 check passed
@@ -17,18 +17,22 @@ pub struct PiopParams<F: PrimeField, Curve: SWCurveConfig<BaseField=F>> {
pub(crate) scalar_bitlen: usize,

// Length of the part of the column representing the public keys (including the padding).
pub keyset_part_size: usize,
pub(crate) keyset_part_size: usize,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This maybe a problem

@davxy
Copy link
Collaborator

davxy commented Nov 23, 2023

@swasilyev @burdges looks like this allows to reduce the size of the serialized stuff by a 3x?

Is possible to leverage this optimization in bandersnatch_vrfs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants