Update images in Identity, Claims, Treasury#945
Conversation
Swader
left a comment
Swader
left a comment
There was a problem hiding this comment.
Requesting changes:
- resize images to max 600px width
- optimize images for size
- remove unused images
- remove the warning from new1 (extension detected) as it might be confusing to people
| select "Set on-chain identity". | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Hm these images don't appear when I run 'yarn kusama:start` on my computer
There was a problem hiding this comment.
Just these two images don't appear
There was a problem hiding this comment.
I would also suggest placing the images inside the assets folder, since most of the images are already in there
There was a problem hiding this comment.
@ansonla3 Did you also want to include new images for https://wiki.polkadot.network/docs/en/maintain-guides-democracy? and https://wiki.polkadot.network/docs/en/claims? These are the last two pages on the Polkadot Wiki that need updated images/instructions
|
Please move the images to the |
| @@ -63,16 +63,16 @@ maximum security), you can start by navigating to the Claims app on Polkadot-JS | |||
| account you would like to claim the DOT into and click the blue "Continue" button to proceed. Your | |||
There was a problem hiding this comment.
Can you also include https://wiki.polkadot.network/docs/en/maintain-guides-democracy as an updated page?
lsaether
changed the title
lsaether
changed the title
|
Looks okay to me. Are you planning to do the Democracy page in this PR or should we open a separate issue / PR for that? |
| select "Set on-chain identity". | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Could you update these images? they are still the old ones from the wiki before the UI update
| select "Set on-chain identity". | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
the first two images here are quite fuzzy and difficult to read, could you retake them?
hm. I don't see the UI on the democracy page that needs to update since the whole operation is done using the "extrinsic" tab. maybe I miss something? @krichard410 |
I was thinking since the extrinsics page itself was updated on the UI (the buttons, etc.), having new images might help the wiki consistent. I think it'd be also less confusing to a user if all the images were updated. |
| voting on it. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
This image doesn't exactly match what the text above is describing it as. I'm thinking for users, it would make most sense to place an image that has a proposal in the treasury rather than the page itself.
| neither accepted nor rejected until more council members weigh in. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Same point here - the image doesn't exactly fit with the text that's describing it
|
Merging this to keep things moving - will update Democracy images in a new PR. |
4 participants
https://guide.kusama.network/docs/en/mirror-learn-identity
https://guide.kusama.network/docs/en/mirror-learn-treasury