Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial treasury docs #5678
Initial treasury docs #5678
Changes from 11 commits
70b8b6c
fddaba7
cdbd04c
a807836
ae2424e
08b6b24
7d60b8d
b0ae53b
7d8976d
e84af3e
ff63c49
a6f0852
3f857d2
8487766
6fc1ef0
b34ffee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? How can the conversion rate be fixed, given the assets are volatile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant a fixed point, not a fixed rate, although I think that is the case anyway, as the rate is a
FixedI128
set in the StorageMap and can be updated. not sure what the strategy is to maintain it unless I am misunderstanding something.For more detail, take a look here, and how the rate is set in the pallet: https://github.com/paritytech/polkadot-sdk/blob/475e7a147676a4e7a9d255ddc7969dd35ea22882/substrate/frame/asset-rate/src/lib.rs#L18