Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add General Tools Page & Block Time Estimator (#3052) #3065

Closed
wants to merge 4 commits into from
Closed

Add General Tools Page & Block Time Estimator (#3052) #3065

wants to merge 4 commits into from

Conversation

salmad3
Copy link
Contributor

@salmad3 salmad3 commented Mar 1, 2022 •
edited
Loading

@a-jwc: created a tools page under "general" and a block time estimator component. #2766

Extension of #3052

@a-jwc
Add General Tools page and Block Time Estimator (#3052)
91897cb 
* update wording

* formalizing

* typo

* calculation complete

* complete calculate new block height

* make fat arrow

* comments and clean

* add convertDateToHours shell function

* fix improve wiki contribute button routing

* add intial general/tools page

* move and format

* wip: tools page

* change to ts

* implement hours or future date to block height

* init estimator

* rename tool

* remove abs for past blocks

* add seconds; rename; add row col to result

* edit tools page description

* add asterisk

* add custom block time input

* edit block time label

* add default block time

* rename var; remove comment

* add clean up function; add const DEFAULT_BLOCK_TIME

* type "text" -> "number"; remove defaultValue prop

* require -> import
@salmad3 salmad3 added A2 - Please Review Pull request is ready for review. A0 - Do Not Merge Pull request should not yet be merged. 1KC Tasks for the 1KC Program labels Mar 1, 2022
@salmad3 salmad3 changed the title Add General Tools page and Block Time Estimator (#3052) Add General Tools Page & Block Time Estimator (https://github.com/w3f/polkadot-wiki/pull/3052) Mar 1, 2022
@salmad3 salmad3 changed the title Add General Tools Page & Block Time Estimator (https://github.com/w3f/polkadot-wiki/pull/3052) Add General Tools Page & Block Time Estimator (#3052) Mar 1, 2022
@salmad3 salmad3 self-assigned this Mar 1, 2022
@salmad3 salmad3 removed the A0 - Do Not Merge Pull request should not yet be merged. label Apr 12, 2022
@salmad3
Copy link
Contributor Author

salmad3 commented Apr 12, 2022 •
edited
Loading

tested locally and lgtm. This can arguably exist in the misc. Also, may want to consider enhanced UI instead of using <Form.label> to present o/p

image

but failing CI as:

Error:  Docusaurus Node/SSR could not render static page with path /docs/tools because of following error:
ReferenceError: Buffer is not defined
    at Object.94636 (main:145176:29)
    at __webpack_require__ (main:174938:42)
    at Object.91051 (main:144917:14)
    at __webpack_require__ (main:174938:42)
    at Object.98287 (main:145246:22)
    at __webpack_require__ (main:174938:42)
    at Object.55159 (main:142269:18)
    at __webpack_require__ (main:174938:42)
    at Module.38136 (main:28293:17)
    at __webpack_require__ (main:174938:42)
[INFO] It looks like you are using code that should run on the client-side only.
To get around it, try using `<BrowserOnly>` (https://docusaurus.io/docs/docusaurus-core/#browseronly) or `ExecutionEnvironment` (https://docusaurus.io/docs/docusaurus-core/#executionenvironment).
It might also require to wrap your client code in `useEffect` hook and/or import a third-party library dynamically (if any).
[success] [webpackbar] Server: Compiled with some errors in 1.54m

@a-jwc

@salmad3 salmad3 added the A3 - Changes Requested Pull Request needs to be updated. label Apr 12, 2022
@salmad3 salmad3 assigned emresurmeli and DrW3RK and unassigned salmad3 May 3, 2022
@alfarok alfarok mentioned this pull request Sep 7, 2022
Closed
2 tasks
@DrW3RK
Copy link
Member

DrW3RK commented Nov 30, 2022

@alfarok closing this PR, as you implemented the core functionality of this one.

@DrW3RK DrW3RK closed this Nov 30, 2022
@alfarok alfarok deleted the 1KC branch December 27, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emresurmeli emresurmeli

@DrW3RK DrW3RK

Labels
1KC Tasks for the 1KC Program A2 - Please Review Pull request is ready for review. A3 - Changes Requested Pull Request needs to be updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salmad3 @DrW3RK @emresurmeli @a-jwc