Skip to content

UpLink Open Grant Proposal#412

Closed
AndreFratelli wants to merge 1 commit intow3f:masterfrom
AndreFratelli:master
Closed

UpLink Open Grant Proposal#412
AndreFratelli wants to merge 1 commit intow3f:masterfrom
AndreFratelli:master

Conversation

@AndreFratelli
Copy link
Copy Markdown
Contributor

Grant Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the Terms and Conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once the first milestone has been accepted.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 11, 2021

CLA assistant check
All committers have signed the CLA.

@mmagician
Copy link
Copy Markdown
Contributor

@AndreFratelli Thanks for the application, sounds interesting.
After a quick look, it seems that there are still a couple of things missing:

  • Perhaps you could be more explicit and elaborate on milestone deliverables, and how each sub-deliverable ties into the substrate techstack?
  • TODOs are still present in the application file
  • CLA needs signing

@alxs alxs self-assigned this May 12, 2021
@AndreFratelli
Copy link
Copy Markdown
Contributor Author

AndreFratelli commented May 12, 2021

Hi, @mmagician,

Thank you for the feedback; forgot about those TODOs, I'll fix it.

Regarding the CLA, the link tells me that I have already agreed, but the status is not updating. Any recommendations?

@mmagician
Copy link
Copy Markdown
Contributor

It seems like your commit has two author accounts. I imagine one of them hasn't signed the CLA?

@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 12, 2021

Looks like the commit was made using an email address that isn't associated with your account. Adding andrefrancisco@MBP-de-Andre.hype to your GitHub account should do the job. The shared authorship is odd, I don't see where GitHub is picking this up.

@AndreFratelli
Copy link
Copy Markdown
Contributor Author

@alxs that's my macbook, I have no idea how to add that to github :| where did you even find that?

@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 12, 2021

It's the email address used to create the commit, which I found by looking at its patch file. Here are instructions on both adding an address to your GitHub account and modifying your commit email address on Git.

@AndreFratelli
Copy link
Copy Markdown
Contributor Author

@alxs thank you, that helped a lot. Still had to figure out to squash everything with the new email, and then it was the user name. But it seems good now. Do I need to do anything else to trigger a new review?

@AndreFratelli
Copy link
Copy Markdown
Contributor Author

Hi, @alxs , @mmagician ,

Is there anything else that I should do? All seems complete for now, but I'd rather make sure.

Kind regards.

@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 18, 2021

Thanks André, looks good. I'll try to get this ready to review for the rest of the team quickly as I remember you wanted to start ASAP.

Right now the biggest problem I see is what @mmagician mentioned previously, i.e. it's not very clear how most of these deliverables relate to Substrate/Polkadot. For milestones 2 and 3 this is particularly unclear. The Hype SDK server port sounds very general-purpose (also what platform are you porting it from?) and it would be good if you could explain how exactly it will interoperate with Substrate. For a milestone this large we would also expect a more precise specification, i.e. could you describe what "cryptographic processes, authentication" and "business logic to configure and manage communication links" exactly this will provide? Assuming it does interoperate with Substrate. If otherwise this would in principle be an endpoint that can be used to relay Substrate transactions as much as anything else, it could be hard to get it accepted. Our grants are pretty focused on Substrate/Polkadot.

Also maybe I'm missing something, but I'm a bit puzzled by the order of the milestones. Wouldn't the Android app depend on the other milestones?

@AndreFratelli
Copy link
Copy Markdown
Contributor Author

@alxs thank you for your feedback, it's very helpful.

The system we're proposing does not directly integrate with Substrate/Polkadot, but rather enables devices without Internet to connect to those networks. In other words, this is technology that works mostly on the end devices, meaning that those without Internet can still process transactions. As you seem to have understood, this is done by relay.

If I understand correctly, this isn't something that you'd expect to be accepted, is that correct?

@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 18, 2021

I'd say it depends on the degree of coupling. If the system was tailored to Substrate and only allowed such devices to connect to Substrate chains, we may be interested. However as I understand it, it would simply allow devices without internet to connect to the internet, in which case we would most likely not be able to fund the entire project. However we can still fund the parts of it that concern the integration with Substrate.

What I'd initially understood was that you would implement this system with an embedded pay-as-you-go scheme that would be processed directly on some Substrate chain. That's also something we'd potentially be interested in. Hope this makes sense.

@AndreFratelli
Copy link
Copy Markdown
Contributor Author

@alxs, makes perfect sense.

The system we're proposing is deeply coupled with Substrate. Notice that this is not meant to provide general Internet reachability; it does not enable users to go on Facebook, or process transactions with MasterCard. What we're proposing enables a device without Internet to process transactions on a Substrate network, and nothing else. The use case is that if I don't have Internet I can still communicate with the Substrate network, check my balances and process transactions. Your second interpretation is closer to what we're proposing. I'll try to make that clearer.

Thank you once again.

UpLink Project Description

Fixing user to sign CLA

UpLink proposal

UpLink proposal
@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 19, 2021

Thanks for the clarification. Let me know when you're done with the changes and don't forget to address the feedback in my comment above.

@andre-francisco andre-francisco mentioned this pull request May 24, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants