updating BTC signer to BlueWallet, as requested for Milestone 1 approval#987
Merged
Noc2 merged 1 commit intow3f:masterfrom Jun 14, 2022
Merged
updating BTC signer to BlueWallet, as requested for Milestone 1 approval#987Noc2 merged 1 commit intow3f:masterfrom
Noc2 merged 1 commit intow3f:masterfrom
Conversation
5 tasks
Contributor
Author
|
This PR is associated with the M1 Delivery PR here: w3f/Grant-Milestone-Delivery#451 |
lucasvanmol
approved these changes
Jun 14, 2022
alxs
approved these changes
Jun 14, 2022
Noc2
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a modification to an already approved proposal to specify that we've switched the signer from Spectre or Caravan to BlueWallet. We also set the
xpubdirectly into thenbvpallet rather than theidentitypallet.