Skip to content

Supersig: like multisig, but with superpowers! 💥#959

Merged
semuelle merged 7 commits intow3f:masterfrom
decentration:master
May 24, 2022
Merged

Supersig: like multisig, but with superpowers! 💥#959
semuelle merged 7 commits intow3f:masterfrom
decentration:master

Conversation

@decentration
Copy link
Copy Markdown
Contributor

This is Decentration's first grant proposal to Web3. We view this simple, suitable and potentially pervasively used pallet as a great opportunity to develop an ongoing relationship with Web3 Foundation, given that we have shared and aligned interests.

key features that improve on the mulitsig pallet

  • add/remove members,
  • supersig account is fixed, not a composite of its accounts, like multsig.
  • enumerated quorum (simpleMajority, superMajority), instead of fixed x/n threshold.
  • option to create Super Beneficiary, this beneficary only needs 2/n threshold, while any transaction without Super Beneficary must have superMajority.

These palletsimprovements have already created a lot of interest and feedback from people in the community, so we believe it's a valuable coordination of resources.

We also believe in building things people need rather over-engineering without validation. The simplicity of this pallet is a great example of this.

For which grant level are you applying?

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $50,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • I have read and understood the FAQs, application guidelines and announcement guidelines.
  • A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledge the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.
  • I prefer the discussion of this application to be in a private Element/Matrix channel. My username is: @_______

How Did You Hear About our grants program?

  • Social Media
  • Hackathon
  • Personal Recommendation
  • Substrate Builders Program
  • Investor/VC
  • Online Search
  • Other: Substrate Seminar Crowdcast

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 19, 2022

CLA assistant check
All committers have signed the CLA.

laboon
laboon previously approved these changes May 20, 2022
Copy link
Copy Markdown
Collaborator

@laboon laboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Excellent use-case. This is something that I personally would find useful (maybe that is not the best definition of "excellent", since I am a bit biased towards my own use cases of course, but that's at least one person that will use it)
  2. Good technical description
  3. Team is capable of developing a pallet

Approved

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Sounds interesting. Something to be aware of: We usually sign at the beginning only one grant per team and we just approved: #949 So could you explain what your relationship with them is? Keep in mind that we can also make an exception to this rule. Also, you still need to sign the CLA and could you add the delivery tables to milestone 1 and 2, including the default deliverables of the template 0a-0d.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label May 20, 2022
@decentration
Copy link
Copy Markdown
Contributor Author

only one grant per team and we just approved: #949 So could you explain what your relationship with them is? Keep in mind that we can also make an exception to this rule.

Hi @Noc2, indeed. Rusty Crewmates are an engineer DAO. They have core educational objectives, which have been funded in #949, but they also train and provide engineering talent to other chains, teams and communities for Substrate. Edgeware and Kabocha being their first partners. Nathan (mentioned in this proposal) is a Rusty Crewmate, who went through their training. He is one of the full time FTE's in our milestone 1. He is not mentioned in #949. The only crossover in the two applications is Timothee who is busy on #949, but providing very light support in this application. I thought i put his name here because he deserves some credit, but not making up the FTE calculation.

In the future Rusty Crewmates will be peppered around many Substrate chain teams, and they set a high bar, so beneficial for all!

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. This sounds good to me and I’m generally willing to go ahead with it. However, milestone 3 is currently very loosely defined. Could you add more details to it, for example benchmarking or what are the necessary updates? Otherwise I would suggest simply removing milestone 3 and immediately deliver everything with milestone 2.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented May 23, 2022

And there seems to be an issue with the formatting of your last milestone.

@decentration
Copy link
Copy Markdown
Contributor Author

Hi David @Noc2, thanks for feedback. I updated milestone 3 to add more colour. It's an essential part of our process, because it allows us to get feedback from both milestone 1 (pallet) and milestone 2 (UI), and to make detailed and/or holistic changes. (Vague because of unknowns). I also added Benchmarking task to milestone 1. Let me know if anything is not detailed enough?

Noc2
Noc2 previously approved these changes May 23, 2022
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I’m happy to go ahead with it and will mark the application as ready for review.

@Noc2 Noc2 requested a review from laboon May 23, 2022 11:06
@semuelle semuelle added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels May 23, 2022
Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one issue:

| 0b. | Documentation | We will provide both **inline documentation** of the code and a basic **tutorial** that explains how a user can (for example) spin up one of our Substrate nodes and send test transactions, which will show how the new functionality works. |
| 0c. | Testing Guide | Core functions will be fully covered by unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. |
| 0d. | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. |
| 0e. | Article | We will publish an **article**/workshop that explains [...] (what was done/achieved as part of the grant). (Content, language and medium should reflect your target audience described above.)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the template text from all Article deliverables and replace them with what you are actually planning to publish?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @semuelle, thanks for the feedback, i have improved the deliverables for the three milestones. Let me know if anything needs more clarity?

laboon
laboon previously approved these changes May 24, 2022
@decentration decentration dismissed stale reviews from laboon and Noc2 via 8742d9b May 24, 2022 09:32
@Noc2 Noc2 requested a review from semuelle May 24, 2022 13:33
Copy link
Copy Markdown
Contributor

@hakan-w3f hakan-w3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @decentration , I think Supersig can be instrumental in so many use-cases, and achieve wide adoption.

@Noc2 Noc2 requested a review from laboon May 24, 2022 14:06
Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semuelle semuelle merged commit d201fb1 into w3f:master May 24, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@tdelabro
Copy link
Copy Markdown
Contributor

Hey,
I'm a bit late to the party, but I want to thank you all for entrusting Kabocha, Ramsey, and RustyCrewmates with this grant.
We are smoothing some rough edges on the RPC side right now.
I think you are going to like the result!

@Polkadot-Forum
Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/introducing-kabocha-an-experimental-kusama-parachain-incubated-by-the-edgeware-community/327/1

@ramseykes
Copy link
Copy Markdown
Contributor

ramseykes commented Sep 13, 2022

I can confirm I am @decentration, and that is my main account.

@keeganquigley
Copy link
Copy Markdown
Contributor

Hey @decentration any updates on milestone 2? How are you coming along?

@decentration
Copy link
Copy Markdown
Contributor Author

decentration commented Dec 15, 2022

Hey @keeganquigley, thanks for checking in. Both Milestone 2 and 3 are almost done, will put those through shortly when it’s complete. Hope that’s ok? Cheers.

@keeganquigley
Copy link
Copy Markdown
Contributor

Thanks for the update @decentration yep sounds good, just let us know if you think the deliveries will be delayed by more than 2 weeks.

@keeganquigley
Copy link
Copy Markdown
Contributor

Hi @decentration just checking back in with a friendly reminder. If M2 is complete I would recommend submitting it first and then submit M3 in a separate PR when it's done. Otherwise if you are still working on it, please submit an amendment to have the committee approve an extension. Thanks!

@decentration
Copy link
Copy Markdown
Contributor Author

decentration commented Jan 5, 2023

Hi @keeganquigley,

Just to clarify, do you mean I can submit to the committee an ammended for time? Becuase we don’t need to amend the application for any changes of what will be delivered. I would prefer not to request any amendment if I don’t have to.

Tbh I wasn’t aware of the time urgency, if you look at M1, we completed the work a long time before the request for payment of the milestone. If we knew prior that there was an urgency to deliver within a 3 month period we would have done so. This grant application was approved much longer than 3 months ago you see.

Apologies if there is an expectation of prompt delivery. The usefulness on of our work is dependent on it being used on a live parachain, which was also a process which I have been working on along side this project. The pallet is now in a live parachain on Kusama (Kabocha), which I have also launched, so this work is most definitely active and a priority!

Could you tell me what the situation with the Builders Programme? It is something that I have not yet utilised. The substrate stackexchange is very helpful, but more support in relation to Polkadot js apps might speed this up.

Kind regards,

Ramsey

@keeganquigley
Copy link
Copy Markdown
Contributor

keeganquigley commented Jan 5, 2023

Thanks for the update @decentration. That's not a problem, I was mostly just asking for a progress update and whether or not separating them was a possibility.

Yes, to answer your question, the amendment would just be for updating the timeline, which generally is easy to get the committee to approve.

But no worries, we mostly just want to make sure the project is active and being worked on. If you think there will be significant delays, please let us know and consider submitting an amendment.

Regarding the Substrate Builder's Program, the program is active, and you can apply on the site. Otherwise, the grants team also forwards your information to the SBP upon completion of the grant, who can provide further resources and support. I hope this info helps and let me know if you have further questions!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants