Skip to content

Add application for SubDAO Chrome Extension#392

Merged
mmagician merged 3 commits intow3f:masterfrom
SubDAO-Network:master
May 6, 2021
Merged

Add application for SubDAO Chrome Extension#392
mmagician merged 3 commits intow3f:masterfrom
SubDAO-Network:master

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 27, 2021

Add application for SubDAO Chrome Extension

Grant Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the Terms and Conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once the first milestone has been accepted.

Add application for SubDAO Chrome Extension
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 27, 2021

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 27, 2021

Hi @Noc2 , we submit a new application for a Chrome Extension which has polkadot wallet integrated. Could you help to review this application?

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. In general, @semuelle should probably also take a look at the application, since he reviewed your last delivery. Regarding the deliveries in the table, could you be more specific in the table itself. For example it currently only says “Source Code: We will provide the source code of this extension.” That is not something we can really test. What functionality are you going to implement? Which programming language, etc. Why did you choose AGPL instead of Apache, MIT, etc? Furthermore, could you also add an example DAO to the deliveries, that can be used together with the extension?

@Noc2 Noc2 requested a review from semuelle April 28, 2021 16:05
@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Apr 28, 2021
Update application according to the comments
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 29, 2021

Thanks for the application. In general, @semuelle should probably also take a look at the application, since he reviewed your last delivery. Regarding the deliveries in the table, could you be more specific in the table itself. For example it currently only says “Source Code: We will provide the source code of this extension.” That is not something we can really test. What functionality are you going to implement? Which programming language, etc.

@Noc2 Thanks for your comments. The application is updated. @semuelle could you please help to continue the review?

Why did you choose AGPL instead of Apache, MIT, etc?

Since we will use some source code with an AGPL license, we have to follow it and keep it.

Furthermore, could you also add an example DAO to the deliveries, that can be used together with the extension?

Sure, an example DAO will be provided as default to verify this extension.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Apr 30, 2021

Thanks for the quick reply. Could you integrate the example into the deliveries? Ideally you would also define what “ and so on” means.

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 30, 2021

Thanks for the quick reply. Could you integrate the example into the deliveries? Ideally you would also define what “ and so on” means.

Thanks for the comments. Sure, will update it in minutes.

Add examples for features in application
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 30, 2021

Thanks for the quick reply. Could you integrate the example into the deliveries? Ideally you would also define what “ and so on” means.

Updated. Could you help to check it?

Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks good to me. I will share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels May 3, 2021
Copy link
Copy Markdown
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting, good luck!

@mmagician mmagician enabled auto-merge (squash) May 3, 2021 10:15
@alxs
Copy link
Copy Markdown
Contributor

alxs commented May 4, 2021

Hey @wannam. May I ask you to please remove the Web3 Foundation logo from your list of partners here? We explicitly don't partner with anyone. Thanks in advance.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 4, 2021

Hey @wannam. May I ask you to please remove the Web3 Foundation logo from your list of partners here? We explicitly don't partner with anyone. Thanks in advance.

Hi @alxs, thanks for the reminder! It's our test design for the new website, not official yet. The official website is https://subdao.network. Already the repo is removed from our org, and the link is disabled.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 4, 2021

@semuelle Could you help to continue the review?

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented May 6, 2021

I am very excited about a snappy DAO frontend.

Could you explain why you chose to include Twitter and Facebook integration into it? Their use is not required, correct? In line with the decentralisation theme, wouldn't it make more sense to include a decentralised messaging protocol?

@ghost
Copy link
Copy Markdown
Author

ghost commented May 6, 2021

I am very excited about a snappy DAO frontend.

Could you explain why you chose to include Twitter and Facebook integration into it? Their use is not required, correct? In line with the decentralisation theme, wouldn't it make more sense to include a decentralised messaging protocol?

Good question! To include Twitter and Facebook is mainly because we would like to let the Web 3.0 world injected into Web 2.0 social networks, and expose the benefits of Web 3.0 technologies. It will let more and more people get involved. We can imagine, people in web 2.0 social networks will be able to use decentralized orgs without interferings from any central governace.

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented May 6, 2021

Thanks for the reply, @wannam. To be honest, I am more of a Do One Thing And Do It Well proponent, but that won't block me from approving this grant. As long as it's not a requirement to use either one and people can fork it to produce a barebones version, I'm happy.

@mmagician mmagician merged commit 95a2e10 into w3f:master May 6, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 6, 2021

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully delivered their first milestone. Please observe the foundation’s guidelines when making any announcements; in particular, don’t announce the grant publicly before you've completed at least the first milestone of the project.

At that point, we will be happy to collaborate on an announcement about the work you’re doing. Please get in touch with us at grantspr@web3.foundation in case you're interested (at least two weeks notice is preferred).

@ghost
Copy link
Copy Markdown
Author

ghost commented May 7, 2021

Thanks for the reply, @wannam. To be honest, I am more of a Do One Thing And Do It Well proponent, but that won't block me from approving this grant. As long as it's not a requirement to use either one and people can fork it to produce a barebones version, I'm happy.

Thanks for your great effort!

chrisli30 pushed a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request May 31, 2021
* Add application for SubDAO Chrome Extension

Add application for SubDAO Chrome Extension

* Update application according to the comments

Update application according to the comments

* Add examples for features in application

Add examples for features in application
@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Sep 3, 2021

@wannam, your milestone submission (w3f/Grant-Milestone-Delivery#203) has now been inactive for more than six weeks. If you are not planning on continuing the project, we would terminate the grant. Please let us know about the status of your grant-related activities asap.

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 6, 2021

@wannam, your milestone submission (w3f/Grant-Milestone-Delivery#203) has now been inactive for more than six weeks. If you are not planning on continuing the project, we would terminate the grant. Please let us know about the status of your grant-related activities asap.

Hi @semuelle , Sorry for the late reply on this milestone delivery. I have update the status of milestone here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants