Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardProtocol application #244

Merged
merged 10 commits into from
Feb 24, 2021
Merged

StandardProtocol application #244

merged 10 commits into from
Feb 24, 2021

Conversation

hskang9
Copy link
Contributor

@hskang9 hskang9 commented Feb 3, 2021

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC or Ethereum address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants at the time of submission.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once we successfully delivered the first milestone.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Are you aware of laminar and their oracle module? In general there are quite a few other teams currently working on oracle modules, see https://github.com/w3f/General-Grants-Program/blob/master/grants/polkadot_stack.md and your applicaiton seems rather expensive too me at the moment (from looking at the current deliveries). Could you reuse potential other oracle modules and focus on improving these? Could you provide more information regarding the cron job and potentially add unit tests and in general additional details about your deliveries (e.g. programming language).

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Feb 4, 2021
@Noc2 Noc2 self-assigned this Feb 4, 2021
@hskang9
Copy link
Contributor Author

hskang9 commented Feb 8, 2021

I see that laminar's oracle module overlaps the milestone 1. I should focus on building oracle client with for getting market datas from binance-rs or coinbase and substrate runtime api o submit xts. There is a trading bot implementation to start with here. For milestone 2, I agree that I think there is some improvement that can be done with pos in the existing laminar oracle module. I will try to improve the existing oracle module. I will put some more details on each milestone this week. Expenses will be cheaper as well.

@hskang9 hskang9 requested a review from Noc2 February 9, 2021 00:33
@hskang9
Copy link
Contributor Author

hskang9 commented Feb 9, 2021

I can start with laminar's oracle module and storage, but the reporting xt should be different in that standard protocol identifies an asset with an identifier. The price report for oracle client to send will be like

#[weight = (some constant determined in weight.rs file)]
fn report(origin, asset_id: T::AssetId, price: T::Balance) {
// check origin is oracle account
let origin = ensure_signed!(origin)?;
ensure!(<Oracles<T>>::get(origin).is_some(), Error::T::NotOracle);
// record price for certain asset from oracle
....
}

@hskang9
Copy link
Contributor Author

hskang9 commented Feb 9, 2021

I also found some differences in orml's oracle module. I think orml considers oracle as controlled network participant, however, Standard's oracle module considers oracles as network participants as same as validators. I think this grant's oracle module diifferentiate from other projects by rewarding oracle providers as same as network validators for maintaining a blockchain.

@hskang9
Copy link
Contributor Author

hskang9 commented Feb 9, 2021

If you need more details on this, please let me know. @Noc2

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and the additional information. I’m generally interested in the application. Do you also accept DAI as a payment? I think we currently don’t pay teams in USDT. And could you potentially add unit tests to the deliveries?

@hskang9
Copy link
Contributor Author

hskang9 commented Feb 9, 2021

Dai is also fine, and I will do unit tests in the deliveries, it will be fun to build this.

@Noc2
Copy link
Collaborator

Noc2 commented Feb 9, 2021

Dai is also fine, and I will do unit tests in the deliveries, it will be fun to build this.

Cool. Could you integrate the unit test into the deliverables?

@hskang9
Copy link
Contributor Author

hskang9 commented Feb 9, 2021

Yes, for the runtime module in oracle, I think I am supposed to provide unit test in each module with test.rs file, am I right? unit tests can be done with era progression using start_era() or session with start_session(). I will write some details for unit test on each milestone.

@Noc2
Copy link
Collaborator

Noc2 commented Feb 9, 2021

Yes unit test for the runtime module would be useful. Let me know once you updated the application.

@hskang9 hskang9 requested a review from Noc2 February 15, 2021 16:37
@hskang9
Copy link
Contributor Author

hskang9 commented Feb 15, 2021

ok done. please check @Noc2

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will share it with the rest of the team.

@hskang9
Copy link
Contributor Author

hskang9 commented Feb 17, 2021

Hello @Noc2, Is there any update or comment?

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Feb 18, 2021
@hskang9
Copy link
Contributor Author

hskang9 commented Feb 24, 2021

@Noc2 @mmagician Is there any update or comment regarding the proposal? if it is, please let me know.

Copy link
Contributor

@Lederstrumpf Lederstrumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hskang9, lgtm!

@Lederstrumpf Lederstrumpf merged commit 0567b13 into w3f:master Feb 24, 2021
@github-actions
Copy link
Contributor

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully delivered their first milestone. Please observe the foundation’s guidelines when making any announcements; in particular, don’t announce the grant publicly before you've completed at least the first milestone of the project.

At that point, we will be happy to collaborate on an announcement about the work you’re doing. Please get in touch with us at [email protected] in case you're interested (at least two weeks notice is preferred).

@hskang9
Copy link
Contributor Author

hskang9 commented Mar 30, 2021

Hello @Noc2 @Lederstrumpf @mmagician , for doing a milestone1, I said that I would make oracle client based on rustlang, but happened to make oracle client with typescript to ship the protocol as people were so interested in this. I kind of felt nervous if the performance of fetching, but it turns out it fetches pretty fast and I have to be careful of axios and polkadot-js packages’ security . Using typescript also had advantages on available lists of apis that can be used regarding the fact most api examples are done in javascript/python. Fetching with typescript also gave me less effort to bring the result from api without specifying data type of result. Due to these, Would it be okay to change oracle client implementation for the grant to be done in javascript instead of rust? I will make optimized one for rust as a separate grant to improve performance.

@hskang9
Copy link
Contributor Author

hskang9 commented Mar 30, 2021

By the way, the oracle implementation is called lumen, you can see the recent code here at https://github.com/digitalnativeinc/lumen

@Noc2
Copy link
Collaborator

Noc2 commented Apr 1, 2021

Hi @hskang9 sounds good to me. Feel free to create a PR to amend the original contract. Also don’t forget to deliver the milestone: https://github.com/w3f/Grant-Milestone-Delivery ;-)

@hskang9
Copy link
Contributor Author

hskang9 commented Apr 2, 2021

ok I will try to finish the milestone 1 in this month ;-).

chrisli30 added a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request Apr 19, 2021
* resource viewer

* changed milestone 3

* quadratic-funding (w3f#227)

* quadratic-funding

* add license, unit test and a standalone minimalistic frontend to spec

* add SEOR code-less smart contract platform application (w3f#205)

* add SEOR code-less smart contract platform application

* update deliverable & add future plans

* add multi-chain support in Milestone 2 & 3's deliverable

* formart the subtitles of 'Project Details' segment

* Polkastarter Grant Application (w3f#204)

* Make Polkastarter Grant Application

* Added screenshots

* Added testing guides

Co-authored-by: Tiago Martins <[email protected]>

* Added curve market maker (w3f#225)

* Added Zondax maintenance+recovery extensions+support (w3f#234)

* Create polkakeeper.md (w3f#200)

* Create polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

Added UI User stories, and more detail on the milestones

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

* Update polkakeeper.md

Co-authored-by: Caspar Oostendorp <[email protected]>

* Readmefixing (w3f#241)

* upgrade readme

* fix icons

* smaller icons

* correct icons

* Update README.md

Updated Evaluators

* Update welcome.yml (w3f#242)

* Update welcome.yml

Update Welcome message

* Update welcome.yml

updated

* Create proposal of stone index on substrate

* Updated the BTC payment address

* draft of pallet design

* Added more details of public functions

* Added back the mandatory deliverables

* Added desc for public exposed methods

* Adjusted the budget

* Revised the deliverables

1. Merge the token module into indexed basket management module
2. Made it more clear for DEX integration
3. Update the sequence of deliverables

* Create AlgoCash.md

* Update AlgoCash.md

* Update AlgoCash.md

* Update AlgoCash.md

* Update AlgoCash.md

* Update AlgoCash.md

Update the approach of further 500,000 share token distribution

* Update AlgoCash.md

Add contract specification

* Update AlgoCash.md

* Update README.md (w3f#250)

As discussed on Element, David, I've added Edgeware Grants and Bounties under the other grant programs header.

* Update welcome.yml

fix html </b>

* Create php-scale-lib.md

* Payment change

* Upgradeability

* Add missing milestone title

* Reduce scope by removing milestone 2

Milestone 2 was deemed too uncertain to be part of the initial grant.
Depending on the results of the first milestone, we will consider
submitting another proposal with more concrete steps.

* Update pull_request_template.md

* Denominating in usd (w3f#253)

* Update application-template.md

denominating in USD

* Update README.md

* Create starry_network.md

* Rename starry_network.md to Starry_Network.md

* Update Starry_Network.md

* update Ecosystem Fit

* update overview

* update architecture

* remove ecosystem fit and add additional Information

* update overview

* Update Starry_Network.md

* add nft dao architecture image and reduce price

* Added user story about NFT DAO, update demo link

* reduce from 12000 DAI to 10000 DAI

* Update pull_request_template.md (w3f#261)

* Update kylin_network.md (w3f#259)

Update the original contract based on grant evaluation comments. [Here](w3f/Grant-Milestone-Delivery#98)

Co-authored-by: wannam2049 <[email protected]>

* Unified TOC and language with general grants (w3f#264)

* Update sensio_network.md

Second milestone of senseo will no longer be delivered

* Remove forum link (w3f#269)

* NewOmega Application (w3f#243)

* Add newomega application

newomega: Fix alignment

newomega: More details

newomega: Improve formatting

* newomega: Include github link to solidity contracts in deliverables

* newomega: Update deliverables to reflect file rename

* newomega: Update deliverableremove third milestone, tweak price

* newomega: more precision in milestone 2 definition

* dotmog application

* Create bright_treasury.md

* Update currency to DAI, add DoD

* Update README.md

Updated Committee

* Update .gitignore (w3f#279)

Co-authored-by: Aleixo Sánchez <[email protected]>

* Delete .DS_Store

* StandardProtocol application (w3f#244)

* Add Standard Protocol Application

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Create application-template.md (w3f#276)

* Create application-template.md

- Some clarifications and highlighting based on past issues,
- mention licensing,
- more emojis ✊,
- ask for 
  - short and long term plans,
  - community & contributors,
  - status of project before grant,
  - previous grant applications,
  - work done.

* Apply suggestions from code review

Co-authored-by: Aleixo Sánchez <[email protected]>

* Update applications/application-template.md

Co-authored-by: Aleixo Sánchez <[email protected]>

Co-authored-by: David Hawig <[email protected]>
Co-authored-by: Aleixo Sánchez <[email protected]>

* Ask for follow-up grant info (w3f#280)

* Update README.md

* fix headings (w3f#285)

* SkyePass application (w3f#212)

* add application for skyepass

* update porposal

* update: identity solution spec

* updates on milestone desc

* update milestone descp

* update milestones

* update total cost

* update milestone spec

* delete status col

* Polkadot UI Web Identicon + Angular Identicon (w3f#252)

* Submission of the project grant template

* Adding repositories for Angular and Web Identicon projects

* Deliverable + future plans update

* Grant Amount Update

* Create ZeroPool.md (w3f#208)

* add ZeroPool.md

* remove the last milestone

* fix typo

* Update ZeroPool.md

* Quadratic Funding Module and Dapp Application (w3f#268)

* Quadratic Funding Module and Dapp Application (#2)

* Added quardratic funding proposal

* Finalized quadratic funding open grant proposal

* Added web app wireframe link and description to project details

* 1. Added finalize function to M1 delivery
2. Adjusted BTC amount to make sure the total funding is within limit

* 1. Move user study out of M2 to future plans due to tightness
2. Fix the paragraph spacing of last commit

* 1. Added UI examples to team's experience section
2. Update the cost denomination to DAI instead of BTC

* 1. Changed BTC address to ERC20 DAI address
2. Added Sybil resistance to future plans

* Added identity module interaction requirement to M1 delivery

* Added project and proposal concepts to UML chart

* Webb Mixer (w3f#216)

* Create MIXER.md

* Update MIXER.md

* Update MIXER.md

* Update MIXER.md

* Update MIXER.md

* Update MIXER.md

* Update README.md (w3f#288)

* Update README.md

* Update application-template.md (w3f#289)

- target audience
- limitations
- `the project` -> `your project`

* Action to automatically label by approvals remaining (w3f#291)

* Github action to label based on approvals (missing)

* Revert "Github action to label based on approvals (missing)"

This reverts commit f6a6b70.

* Github action to label based on approvals

* Create Gluon_decentralized_hardware_crypto_wallet_services.md (w3f#182)

* Create Gluon_decentralized_hardware_crypto_wallet_services.md

* Merge branch 'master' of https://github.com/tearust/Open-Grants-Program

* update btc to dot

* add light node to communicate with DOT. adjust cost based on BTC price change

* update based on discussion. using schnorr and social recovery pellet

* update milestones

* add prerequisites to Schnorr threshold sign

* update using Schnorrkel algorithm

* update to USD

* Update google_sheet_update.yml

* EverlastingCash Web3 Grant Application (w3f#277)

* Create EverlastingCash.md

ELC - An algorithmic stablecoin with reserves

* Update EverlastingCash.md

* Update EverlastingCash.md

* Update EverlastingCash.md

* Update EverlastingCash.md

* Update Linkedin

Co-authored-by: steven <[email protected]>

* approval labeler rewrite (w3f#292)

* Github action to label based on approvals (missing)

* Revert "Github action to label based on approvals (missing)"

This reverts commit f6a6b70.

* Github action to label based on approvals

* approval labeler rewrite

* substrate identity directory (w3f#255)

* substrate identity directory

* substrate identity directory

* added 0a to 0d deliveries to milestone 1

* price changed

Co-authored-by: dark64 <[email protected]>

* A comma (w3f#298)

* Update README as in General Grants repo (w3f#303)

* Update README as in General Grants repo

* Update README.md

Co-authored-by: Aleixo Sánchez <[email protected]>

Co-authored-by: David Hawig <[email protected]>

* Update README.md

Fixing links

* Update README.md

fix rfp link

* Update README.md

fix milestone-deliverables-guidelines link

* Update README.md

Update tech stack/accepted links

* Fix broken links (w3f#307)

* Update MAP-Bridge.md

Termination, see [comment](w3f/Grant-Milestone-Delivery#89 (comment))

* Update MAP-Bridge.md

Added payment address again, just in case

* Update clover_network.md (w3f#310)

* Update shadows-network.md (w3f#309)

* Update README.md

* Update README.md

* Update README.md

* Open Grants Program application for project Delmonicos (w3f#283)

* Update delmonicos.md
+ Application update after questions from Noc2

* Update to address demand from gautamdhameja

* Changed repo url

Repo moved to the newly created Delmonicos organisation

* Update polkadex.md

* Add Treasureland Grant (w3f#218)

* Create Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* Update Treasureland.md

* ChainJS Grant application (w3f#228)

* Create chainjs.md

Adding template for grant proposal

* Update chainjs.md

Adding ChainJS for Polkadot draft proposal

* Update chainjs.md

Corrected title

* Update chainjs.md

formatting

* Update chainjs.md

added ecosystem fit section

* Update chainjs.md

* Update chainjs.md

Removed instructions

* Update chainjs.md

removed instructions

* Update chainjs.md

Added more narrative to future plans

* Update chainjs.md

* Update chainjs.md

Added Kusama support into the grant application, and added more description of the difference between ChainJS and Polkadot.js

* Update chainjs.md

Updated pricing

* Update chainjs.md

Lowering price

* PolkaJ Android Support proposal (w3f#301)

* PolkaJ Android Support proposal

* Update BTC to DAI

* Adjust price based on feedback

* Remove undelivered milestone (w3f#318)

* xtoken - XCM Implementation for Fungible Assets (w3f#316)

* xtoken

* update description

* update

* update payment denomination, and milestone 1 deliverables

* file name change, milestone cost updated

Co-authored-by: Bryan Chen <[email protected]>

* stable-asset.md (w3f#286)

* stable-asset.md

* Update stable-asset.md

* Update stable-asset.md

* Update stable-asset.md

Co-authored-by: Shengda Ding <[email protected]>

* move the application file into its proper folder (w3f#320)

* discount based on hackathon participation (w3f#325)

* Update EVANESCO Legal Structure (w3f#326)

* pallet-maci (Minimal Anti Collusion Infrastructure) (w3f#232)

* Create pallet_maci.md

* Update pallet_maci.md

* Update pallet_maci.md

* Update pallet_maci.md

* discount Apron Network for ParityAsia hackathon award (w3f#323)

* changed the bitcoin address (w3f#330)

* discount deeper network due to hackathon participation (w3f#324)

* Create XPredictMarket.md (w3f#313)

* update the gsheet workflow

* re-estimate the price of milestone (w3f#331)

* Update Apron_Network.md

Remove SDK from milestone and reduce the price

* Update Apron_Network.md

Reduce the price

* Bit.Country Milestone 2 (w3f#305)

* Create bit_country_m2.md

initial draft for m2.

* Update bit_country_m2.md

Finalised the tasks in the milestone.

* Update bit_country_m2.md

minor milestone text update

* Update bit_country_m2.md

update team member

* Update bit_country_m2.md

update image.

* Update bit_country_m2.md

Change the amount to be USD as required.

* Update bit_country_m2.md

Add bootstrap tasks for launching testnet.

* Update grant application. (#1)

Restructure and update wording to improve clarity of deliverables.
Add summary and considerations sections.

* Tech stack and changing NFT native to support NFT

Tech stack and changing NFT native to support NFT

* update Duration

update Duration

* fix typo

Co-authored-by: Shannon Christie <[email protected]>

* removed "Adopt storage", reduced costs (w3f#339)

* Create vera_defi.md (w3f#281)

* Create vera_defi.md

Initial grant application

* Update grant application

* Replace https with http to fix images link.

* Add more details to the milestone

* Update vera_defi.md

Update bio

* Update vera_defi.md

* Clarification on NFT Lending

* Update vera_defi.md

NFT Token development clarification

* Update vera_defi.md

Fix style

* Update vera_defi.md

Fix style

* Update vera_defi.md

Update scope to focus on AssetManager. Use existing NFT implementation instead of building our own.

* Update vera_defi.md

Update cost

Co-authored-by: arbach <[email protected]>
Co-authored-by: Denis <[email protected]>

* Create Parallel.md (w3f#329)

* Auto-merge action (w3f#349)

* NFT Collectibles Wallet (w3f#341)

* NFT Collectibles Wallet

* updating project scope and adjusting cost

* updating estimated duration

* reordering milestone numbers

Co-authored-by: Michael Huntington <[email protected]>

* Clean & fix actions (w3f#359)

* Delete label_approval_count.yml

* Update auto_merge.yml (w3f#360)

* remove m2 (w3f#355)

* Update README.md

* cosmetic fixes

* Subspace (w3f#357)

* first draft

* second draft

* minor edits

* finial revisions

* Rename subspace.md to spartan_poc_consensus_module.md

* adjust license and cost

* adjust license and cost

* no parallel funding from multiple sources

* Update dorahacks-quadratic-funding.md

* Update README + other minor changes (w3f#367)

* Add more info to README

* Track team provenance + minor updates to template

* Update PR template

* Update dorahacks-quadratic-funding.md (w3f#370)

We completed frontend integration with HackerLink. However due to tight schedules we didn't create a demo page based on the substrate-frontend-template (task #2 of Milestone-2). Another reason why we didn't create the simple page is that HackerLink has a complete infrastructure for user registration, project upload / display, etc. The HackerLink code base is not open source. We would like to provide a complete demo of how quadratic funding grant is functioning on a parachain or potentially on Polkadot / Kusama relaychains in the future. Therefore we would like to still submit a milestone. Given that our frontend is not open source and we are only providing a demonstration site that uses our milestone-1 code to provide a service for quadratic funding grant, we are reducing the price to 0 accordingly.

* Delete application-template-cn.md (w3f#372)

Co-authored-by: borispovod <[email protected]>
Co-authored-by: Jiannan Zhang <[email protected]>
Co-authored-by: AKACoder <[email protected]>
Co-authored-by: Polkastarter <[email protected]>
Co-authored-by: Tiago Martins <[email protected]>
Co-authored-by: mikolajsobolewski <[email protected]>
Co-authored-by: Juan Leni <[email protected]>
Co-authored-by: RAMPDEFITEAM <[email protected]>
Co-authored-by: Caspar Oostendorp <[email protected]>
Co-authored-by: semuelle <[email protected]>
Co-authored-by: David Hawig <[email protected]>
Co-authored-by: calvinzhou-rockx <[email protected]>
Co-authored-by: Dohkooo <[email protected]>
Co-authored-by: Junte <[email protected]>
Co-authored-by: gmajor <[email protected]>
Co-authored-by: Hugo Peixoto <[email protected]>
Co-authored-by: Fuling <[email protected]>
Co-authored-by: Aleixo Sánchez <[email protected]>
Co-authored-by: kylin <[email protected]>
Co-authored-by: wannam2049 <[email protected]>
Co-authored-by: celrisen <[email protected]>
Co-authored-by: darkfriend77 <[email protected]>
Co-authored-by: Agnieszka Olszewska <[email protected]>
Co-authored-by: Kasia Łukasiewicz <[email protected]>
Co-authored-by: Aleixo Sánchez <[email protected]>
Co-authored-by: Hyungsuk Kang <[email protected]>
Co-authored-by: Song Zhou <[email protected]>
Co-authored-by: Mor GUEYE <[email protected]>
Co-authored-by: Igor Gulamov <[email protected]>
Co-authored-by: Drew Stone <[email protected]>
Co-authored-by: Kevin Zhang <[email protected]>
Co-authored-by: steve <[email protected]>
Co-authored-by: steven <[email protected]>
Co-authored-by: Ana Milić-Štrkalj <[email protected]>
Co-authored-by: dark64 <[email protected]>
Co-authored-by: Lumena <[email protected]>
Co-authored-by: dego-team <[email protected]>
Co-authored-by: Marc Blinder <[email protected]>
Co-authored-by: Nathan Schwermann <[email protected]>
Co-authored-by: Bette <[email protected]>
Co-authored-by: Bryan Chen <[email protected]>
Co-authored-by: Frank Yin <[email protected]>
Co-authored-by: Shengda Ding <[email protected]>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: eva-networks <[email protected]>
Co-authored-by: Filip Pajic <[email protected]>
Co-authored-by: Sota Watanabe <[email protected]>
Co-authored-by: XPredictMarket <[email protected]>
Co-authored-by: Toney <[email protected]>
Co-authored-by: Ray Lu <[email protected]>
Co-authored-by: Shannon Christie <[email protected]>
Co-authored-by: arbach <[email protected]>
Co-authored-by: arbach <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: yubo-ruan <[email protected]>
Co-authored-by: Michael (GP) <[email protected]>
Co-authored-by: Michael Huntington <[email protected]>
Co-authored-by: J Wagstaff <[email protected]>
chrisli30 pushed a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request Apr 19, 2021
* Add Standard Protocol Application

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md

* Update Standard_Protocol.md
@alxs
Copy link
Contributor

alxs commented Jun 9, 2021

@hskang9 just checking in - where are you with your progress? Also a reminder that if you want to submit the TypeScript implementation for M1 you'd need to submit an amendment via PR first.

@alxs
Copy link
Contributor

alxs commented Jul 5, 2021

@hskang9 given your recent grant application #438, am I correct in assuming you're no longer interested in this project? In that case, we would terminate the agreement. Note that we generally don't award multiple grants in parallel to the same team.

@hskang9
Copy link
Contributor Author

hskang9 commented Jul 6, 2021

We have been interested in this oracle architecture, but had to partner with oracle providers to get data sources and validators for participation. Now that we have a standalone testnet deployed in polkadot-js have channel for validators(thanks to stakenode), we have been finishing building the environment to demo milestone 1. We are currently thinking to apply milestone 1 in kusama parathread as we have finished parathread deployment in local rococo deployment as well. For #438, as bridge off-chain client is an extension of the oracle in this grant, it is general practice to finish this grant's milestones and proceed to bridge. We wanted to be agile, want to publicize our research, and appreciate the review process of w3f grant team, so we made multiple grant proposals. If it is a general practice to finish one grant at a time, we respect the policy and are willing to follow the norm.

@hskang9
Copy link
Contributor Author

hskang9 commented Jul 6, 2021

ETA for milestone 1 demo is second~third week of July, and submission will follow.

@alxs
Copy link
Contributor

alxs commented Jul 7, 2021

Sounds good and yes, that is the general policy. In case it clearly makes more sense for you to work on both grants in parallel, let me know and we can discuss your case on an individual basis. Otherwise I recommend you close the other application and focus on delivering this grant first.

@alxs alxs mentioned this pull request Jul 19, 2021
7 tasks
alxs pushed a commit that referenced this pull request Jul 20, 2021
* add metamask plugin for polkadot grant proposal

* add longterm plan to metamask-plugin-polkadot.md
@hskang9
Copy link
Contributor Author

hskang9 commented Jul 21, 2021

So the bottleneck was that the application had to build a new reward logic and reward curve, but after investigating the staking module and session module, it seems creating new reward logic is not a preferable and efficient way to do it. All callbacks regarding progression of era is managed by the dependancy injection trait of pallet-session and pallet-staking 's SessionManager implementation. if the grant milestone 2 leverages that, I think the grant can be delivered much sooner than I expected. By the way, the grant submission for milestone 1 is ready in runtime and oracle client is ready here.

@hskang9
Copy link
Contributor Author

hskang9 commented Jul 21, 2021

#514 is the amend considering the session callbacks. @alxs please take a look.

@alxs
Copy link
Contributor

alxs commented Jul 21, 2021

Thanks @hskang9, makes sense. Feel free to submit the first milestone following the delivery process as soon as the amendment has been accepted.

@semuelle
Copy link
Member

semuelle commented Nov 4, 2021

Hi @hskang9. Are you still working on the grant? Could you give us a quick update? Anything holding you back?

@alxs
Copy link
Contributor

alxs commented Dec 1, 2021

@hskang9 could you give us an update on your progress? Note that since the current milestone is already very delayed and we previously asked you for an update, if we don't hear from you in the next 2 weeks we will assume you're no longer interested and terminate the agreement.

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 3, 2021

Sorry for late updates, After facing market and bugs in parachains, I think I will contract grant milestone 2 to interoperate with evm precompile that we can ship it for real use case. After market research, current infrastructure in market are focused on for evm now, and it seems evm integration is immediate. Would it be ok to edit grant milestone 2 and finish with new design and impl of evm in standard-evm?(I estimate this would take 1 or 2 months after kusama parachain lease, I believe it will be shipped with canary market solution).

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 3, 2021

I will add milestone 3 as the current milestone 2 for wasm integration. Anyway, I still have interest in oracle grant, and want to finish milestone 2 to be usable in the real market.

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 3, 2021

new PR to add milestone with more technical design will come by this weekend.

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 8, 2021

#732 is out for amendment @Noc2 @semuelle

@alxs
Copy link
Contributor

alxs commented Jan 17, 2022

@hskang9 please note that since we're still waiting for your reply on the amendment and we haven't heard from you in over a month, we'll assume you're no longer interested and terminate the grant if we don't hear from you in the next 2 weeks.

@alxs alxs mentioned this pull request Jan 31, 2022
@hskang9
Copy link
Contributor Author

hskang9 commented Feb 3, 2022

Sorry for late response, I have been busy with our first product launch, and I missed that. I think grant is good to be terminated as we try to approach implementing standard in polkadot ecosystem through evm, so I will post new one soon with shorter milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants