Skip to content

Conversation

@calvinzhou-rockx
Copy link
Contributor

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below CHF 30k at the time of submission.
  • The initial PR contains only one commit (squash if needed before submitting your PR).

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of allowing users to create their own indices is interesting. Before I approve your application, however, you'll need to fill in some of the missing details:

  1. As specified in our application template: Deliverables 0a-0d are mandatory and should not be removed
  2. You need to decide whether the payout is DAI or BTC and only provide one address
  3. Pallets are missing details: Indexed basket management. Take a look at these guidelines for a list of specifications we'd like you to add to the application.

@mmagician mmagician added the changes requested The team needs to clarify a few things first. label Jan 11, 2021
@calvinzhou-rockx
Copy link
Contributor Author

The idea of allowing users to create their own indices is interesting. Before I approve your application, however, you'll need to fill in some of the missing details:

  1. As specified in our application template: Deliverables 0a-0d are mandatory and should not be removed
  2. You need to decide whether the payout is DAI or BTC and only provide one address
  3. Pallets are missing details: Indexed basket management. Take a look at these guidelines for a list of specifications we'd like you to add to the application.

Hi,

Thanks for your comments and we made the changes accordingly for #1 and #3. Regarding to #2, we target to complete this grant within 30k USD, which roughly worths 0.8BTC based on the current market price of BTC, and only BTC address is provided in the proposal

Thanks

@mmagician
Copy link
Contributor

Thanks for the updates. I would be happy to support the project, although I still have some comments:

  1. By reading your application, I develop an understanding that the token module and the Indexed basket management are the same thing (since the latter has purchase_index & redeem_index callables that mint & burn the token, which seems to be the same functionality as your token module)
  2. Rather than building your own DEX module, perhaps you could utilise one of the existing ones? Take a look at the Polkadot stack and you will find a number of DEX modules at various stages of development. I'm confident you will be able to adapt one of these to suit your needs. If this is not the case, you'd need to provide a detailed explanation why. At this point we have quite a lot of DEX modules (and more in development) and unless you are proposing something truly innovative, I'd suggest using one built by the community already.
  3. Especially given the above points, the price is way too high for building out one module with the functionality proposed.

@calvinzhou-rockx
Copy link
Contributor Author

Thanks for the updates. I would be happy to support the project, although I still have some comments:

  1. By reading your application, I develop an understanding that the token module and the Indexed basket management are the same thing (since the latter has purchase_index & redeem_index callables that mint & burn the token, which seems to be the same functionality as your token module)
    [CZ] The understanding is correct
  1. Rather than building your own DEX module, perhaps you could utilise one of the existing ones? Take a look at the Polkadot stack and you will find a number of DEX modules at various stages of development. I'm confident you will be able to adapt one of these to suit your needs. If this is not the case, you'd need to provide a detailed explanation why. At this point we have quite a lot of DEX modules (and more in development) and unless you are proposing something truly innovative, I'd suggest using one built by the community already.
    [CZ] Yes, we'd use existing DEX rather than develop by ourselves, the DEX module is more for integration
  1. Especially given the above points, the price is way too high for building out one module with the functionality proposed.
    [CZ] The concern is valid and we can reduce it to 0.5 BTC, please let us know if it's OK, thanks

Thanks for the response, and replied per question above tagged by [CZ]

@mmagician
Copy link
Contributor

In the light of your responses, please update the application accordingly. Regarding the price: since you are reducing your deliverables from 3 modules to 1, I would expect the price to reflect that.

@calvinzhou-rockx
Copy link
Contributor Author

In the light of your responses, please update the application accordingly. Regarding the price: since you are reducing your deliverables from 3 modules to 1, I would expect the price to reflect that.

Roger that, I hence reduced it to 0.3 BTC

@mmagician
Copy link
Contributor

mmagician commented Jan 22, 2021

Thanks, but your deliverables still include creating a DEX module (please change to indicate you will integrate one of already existing ones). Furthermore, please unify the index management & token modules, since they are not two separate deliverables.
Looking forward to your updates.

1. Merge the token module into indexed basket management module
2. Made it more clear for DEX integration
3. Update the sequence of deliverables
@calvinzhou-rockx
Copy link
Contributor Author

Thanks, but your deliverables still include creating a DEX module (please change to indicate you will integrate one of already existing ones). Furthermore, please unify the index management & token modules, since they are not two separate deliverables.
Looking forward to your updates.

Thanks for the input, and I updated the deliverables accordingly

@calvinzhou-rockx
Copy link
Contributor Author

Hi @mmagician ,

Would like to check if any update since our last changes for deliverables

Thanks
Calvin

@mmagician mmagician added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jan 29, 2021
Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for a delayed reply. I appreciate the updates and I'll share the application with other team members.

@mmagician mmagician self-assigned this Jan 29, 2021
@mmagician mmagician merged commit 8fe3192 into w3f:master Feb 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly while observing the foundation’s guidelines. To that end, we’ve created a badge for grant-winning teams. Here is a link to the download and guidelines.

Once you complete your first grant milestone, would you be interested in collaborating on an announcement about the work you’re doing? If so, then please get in touch with us at [email protected] prior to making the announcement (at least two weeks notice is preferred) so that we can coordinate on timing and content.

Please don’t announce the grant publicly before you finished at least the first milestone of the project.

@alxs
Copy link
Contributor

alxs commented Jun 9, 2021

@calvinzhou-rockx care to share a quick status update on the project, together with an ETA if possible? Your first delivery is by now delayed by several months so if we don't hear something from you soon, we would terminate the grant due to inactivity.

@RouvenP
Copy link
Contributor

RouvenP commented Oct 18, 2021

hi @calvinzhou-rockx we transferred the payment for M1 today.

@calvinzhou-rockx
Copy link
Contributor Author

hi @calvinzhou-rockx we transferred the payment for M1 today.

Hi @RouvenP , this is to confirm the payment of 0.3 BTC is received, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants