-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrivaDEX MVP: Grant Application for a cross-chain DEX aggregator #1398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the grant application. First of all, you can always apply for a grant for more than 30k. In this case, it’s simply a level 3 grant and requires two additional approvals. Could you update the level in your grant application accordingly? Apart from this, why do you focus on Phala Network and Phat Contracts for this specific implementation? Something to be aware of is that we usually don’t want to support a specific parachain, but rather try to be as objective as possible. Additionally, we are not the best team when it comes to evaluating these Phat Contracts. Have you already talked to Phala directly about it? That said, we would definitely still be interested in supporting the milestones that don’t contain the phat contracts since the open-source code is probably useful for other aggregators as well (milestones 1 and 2).
@Noc2 Thanks for the feedback - updated! I have bumped the level from 2 to 3. I haven't squashed commits yet to be able to easily track changes to the proposal for now. I think evaluating the Phat Contract code will actually be relatively straightforward since each component can be tested in isolation. In my opinion, a lot of the components in this project that will be useful for other teams/projects reside in milestone 3. There currently are few examples of raw interfacing with XCM, extrinsics, etc. from a lightweight computing environment (i.e. ruling out blockchain runtimes and subxt-like libraries that generate large artifacts); this DEX aggregator provides exactly those in the executor module. Milestone 4 brings the MVP to completion, which directly brings value to Polkadot. Thus I would love to have milestones 3-4 included in the proposal, but if you still have any concerns please let me know! FAQs on Phat ContractWhat is Phat Contract?
Why use Phat Contract?
How can we evaluate Phat Contract?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed reply. I think it also makes sense to support the phat contract part, and I’m generally happy to go ahead with it and mark it as ready for review. But I have one additional question: Have you already looked into front running and other potential ways to attack your solution? We are aware that with XCM comes front-running, and I think it’s better to make these things transparent for everyone immediately, which is why we have an interest in supporting any kind of research in this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the detailed proposal.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, great cross-chain idea! Please keep on providing updates
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Project Abstract
Our team is building PrivaDEX, a cross-chain DEX aggregator that enables cross-chain trading and unifies Polkadot's fragmented DeFi ecosystem. We request 55,000 USDT to finish developing our MVP and launch it in Q1 2023.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)