Merged
Conversation
We will need a solid rationale to merge WasmEdge support upstream into the official Substrate repo. So, we changed the order of tasks to complete the performance eval first and then to propose a merge PR. That means shifting the PR task from milestone 2 to 3. We have also found that the Substrate approach of using host functions requires a lot of changes in the WasmEdge Rust SDK. That has caused a delay and extra engineering work for the project (already completed). We will keep the total project budget the same, but respectfully ask for each milestone payment to stay the same to account for the extra work needed for milestone 2. Signed-off-by: Michael Yuan <michael@secondstate.io>
|
|
5 tasks
alxs
added
ready for review
Noc2
approved these changes
Aug 26, 2022
takahser
approved these changes
Aug 26, 2022
Micassa93
approved these changes
Aug 27, 2022
laboon
approved these changes
Aug 29, 2022
SBalaguer
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will need a solid rationale to merge WasmEdge support upstream into the official Substrate repo. So, we changed the order of tasks to complete the performance eval first and then to propose a merge PR. That means shifting the PR task from milestone 2 to 3.
We have also found that the Substrate approach of using host functions requires a lot of changes in the WasmEdge Rust SDK. That has caused a delay and extra engineering work for the project (already completed). We will keep the total project budget the same, but respectfully ask for each milestone payment to stay the same to account for the extra work needed for milestone 2.
Signed-off-by: Michael Yuan michael@secondstate.io
Grant level
#862