societal-saas-pricing-m1

[gfox1]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1671

[Ali-Usama]

Hi @gfox1 and @okalenyk. Thank you for submitting the milestone. However, I'm getting this error on running the docker script:

$ bash scripts/docker_run.sh 
*** Start Societal Node ***
[+] Building 0.0s (0/0)                                                                                                                                                               
[+] Creating 1/0
 ✔ Network societal-node_default  Created                                                                                                                                        0.0s 
[+] Running 6/6
 ✔ dev 5 layers [⣿⣿⣿⣿⣿]      0B/0B      Pulled                                                                                                                                 420.4s 
   ✔ 01085d60b3a6 Pull complete                                                                                                                                                318.7s 
   ✔ 8fcfcb47b1c2 Pull complete                                                                                                                                                410.5s 
   ✔ c1af8e07a1f9 Pull complete                                                                                                                                                410.5s 
   ✔ 28d8d4683eb7 Pull complete                                                                                                                                                413.5s 
   ✔ 170dcfc3956d Pull complete                                                                                                                                                413.5s 
[+] Building 0.0s (0/0)                                                                                                                                                               
Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /host_mnt/home/societal-node/.local

Can you please look into it?

Thanks

[okalenyk]

Hi @gfox1 and @okalenyk. Thank you for submitting the milestone. However, I'm getting this error on running the docker script:

$ bash scripts/docker_run.sh 
*** Start Societal Node ***
[+] Building 0.0s (0/0)                                                                                                                                                               
[+] Creating 1/0
 ✔ Network societal-node_default  Created                                                                                                                                        0.0s 
[+] Running 6/6
 ✔ dev 5 layers [⣿⣿⣿⣿⣿]      0B/0B      Pulled                                                                                                                                 420.4s 
   ✔ 01085d60b3a6 Pull complete                                                                                                                                                318.7s 
   ✔ 8fcfcb47b1c2 Pull complete                                                                                                                                                410.5s 
   ✔ c1af8e07a1f9 Pull complete                                                                                                                                                410.5s 
   ✔ 28d8d4683eb7 Pull complete                                                                                                                                                413.5s 
   ✔ 170dcfc3956d Pull complete                                                                                                                                                413.5s 
[+] Building 0.0s (0/0)                                                                                                                                                               
Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /host_mnt/home/societal-node/.local

Can you please look into it?

Thanks

Hi @Ali-Usama, good catch! I've fixed the problem creating the .local directory before running the docker-compose.

[Ali-Usama]

Thank you for the quick fixes @okalenyk. A detailed evaluation can be found here.

[dsm-w3f]

@okalenyk thank you for the submission and @Ali-Usama thanks for the evaluation. One doubt, the correct license is Apache 2.0 or Unlicense? The deliverables table says Apache 2.0 and in the repository is Unlicense. The evaluation looks good to me. The only points that I would add are that the testing coverage could be higher (~60%) in the pallet and there are some cargo clippy warnings that could be fixed. I'll wait for the answer and possible fix of the license before merging.

[okalenyk]

@okalenyk thank you for the submission and @Ali-Usama thanks for the evaluation. One doubt, the correct license is Apache 2.0 or Unlicense? The deliverables table says Apache 2.0 and in the repository is Unlicense. The evaluation looks good to me. The only points that I would add are that the testing coverage could be higher (~60%) in the pallet and there are some cargo clippy warnings that could be fixed. I'll wait for the answer and possible fix of the license before merging.

Hi @dsm-w3f! Thanks for the review! We've fixed the license as well as clippy warnings in the latest revision of the milestone submission source code. We've also added more unit tests to the dao-subscription pallet to increase the coverage.

[dsm-w3f]

@okalenyk thank you for the improvements and fixes. The milestone is accepted. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.