Skip to content

Create validators_selection_2.md#756

Merged
randombishop merged 1 commit intow3f:masterfrom
miepsik:master
Mar 7, 2023
Merged

Create validators_selection_2.md#756
randombishop merged 1 commit intow3f:masterfrom
miepsik:master

Conversation

@miepsik
Copy link
Copy Markdown
Contributor

@miepsik miepsik commented Feb 19, 2023

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1326 < please fill this in with the PR number of your application.

@randombishop
Copy link
Copy Markdown
Contributor

Thanks for this delivery @miepsik, will evaluate and get back to you in coming days...

@randombishop randombishop self-assigned this Feb 23, 2023
@randombishop
Copy link
Copy Markdown
Contributor

Hi @miepsik !

I am getting an error when I try pip3 install -r requirements.txt

ERROR: Could not find a version that satisfies the requirement torch==1.4.0 (from versions: 1.9.0, 1.10.0, 1.10.1, 1.10.2, 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1)
ERROR: No matching distribution found for torch==1.4.0

My python version is 3.9.6

Also tried after pip install --upgrade pip setuptools wheel but still got the same error.

Can you please provide a fix?

Thank you!

@miepsik
Copy link
Copy Markdown
Contributor Author

miepsik commented Mar 2, 2023

Hi @randombishop , thanks for the feedback.
The environment was setup for python 3.8. I added the description how to run it with python 3.9

@randombishop
Copy link
Copy Markdown
Contributor

@miepsik Thank you for the updated requirements file. Now managed to install and run the tests locally.

But the same error shows in docker build even if it's using python 3.8

Command:

docker build -t "validators_selection:Dockerfile" .

See log file
validator_selection_docker.log

Can you please clean your docker history and see if you can reproduce in your environment, then commit a fix?

Thanks!

@miepsik
Copy link
Copy Markdown
Contributor Author

miepsik commented Mar 3, 2023

@randombishop thanks for the review. They have updated this docker image in the meantime with the newer pip version that no longer holds torch 1.4.0. I changed this version for the one that is available in the pip version in this image

@randombishop
Copy link
Copy Markdown
Contributor

Thank you @miepsik !
Docker works fine now.
Question about deployment and average response time measurements, did you deploy a server and test it as mentioned in the deliveries? I can't find the link in the readme?

@miepsik
Copy link
Copy Markdown
Contributor Author

miepsik commented Mar 6, 2023

Thanks @randombishop . Yes I deployed and tested it. Times were provided in the readme but in a not clear way. Now the time is clearly visible for each of the three endpoints. The server was deployed on my resources and it was turned off after the measurements so there is no link. However, I'm in touch with a team that will deploy this server and use it.

@randombishop
Copy link
Copy Markdown
Contributor

Thanks for the clarification @miepsik, I went ahead and accepted your delivery.
Here are my evaluation notes: https://github.com/w3f/Grant-Milestone-Delivery/blob/master/evaluations/validator_selection_2_randombishop.md

@randombishop randombishop merged commit c26f22e into w3f:master Mar 7, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2023

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding. Common Good projects have a good chance of receiving Treasury Funding.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@randombishop
Copy link
Copy Markdown
Contributor

@miepsik I forwarded your invoice to accounting, please expect up to 2 weeks for processing.
Cheers!

@miepsik
Copy link
Copy Markdown
Contributor Author

miepsik commented Mar 8, 2023

Thanks @randombishop . One more question - can you provide a server for the deployment? We are going to integrate it and the frontend is nearly ready so we need a server to set up the backend

@randombishop
Copy link
Copy Markdown
Contributor

Thanks @randombishop . One more question - can you provide a server for the deployment? We are going to integrate it and the frontend is nearly ready so we need a server to set up the backend

Unfortunately, we don't provide servers to grantees. Maybe you can try a treasury proposal to fund the deployment and maintenance of the solution as a public good for the ecosystem?

@jonasW3F
Copy link
Copy Markdown

jonasW3F commented Mar 9, 2023

I think it really makes sense to get this deployed, otherwise we stop before the finish line. Are we able to extend the grant by a deployment & maintenance phase, such that @miepsik can deploy the code on his own infrastructure?

@randombishop
Copy link
Copy Markdown
Contributor

@jonasW3F I agree with you that this should definitely be deployed and hopefully adopted by the community and ultimately integrated in the staking UX etc.
But with that, the Grants Program policy is generally a no-go for centralized deployments and hosting.
We can support maintenance grants to fix or add features to existing repos; but not hosting.
That's why I recommended a treasury proposal in-chain instead. Given the low cost of servers it should be possible to convince the community to accept funding it as a public good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants