Skip to content

Delivery: Project Aurras MVP - Phase 2 - Milestone 2#736

Merged
dsm-w3f merged 4 commits intow3f:masterfrom
MuhammedIrfan:aurras_mvp_2-m2
Jun 19, 2023
Merged

Delivery: Project Aurras MVP - Phase 2 - Milestone 2#736
dsm-w3f merged 4 commits intow3f:masterfrom
MuhammedIrfan:aurras_mvp_2-m2

Conversation

@MuhammedIrfan
Copy link
Copy Markdown
Contributor

@MuhammedIrfan MuhammedIrfan commented Feb 8, 2023

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#814

@0xCaso
Copy link
Copy Markdown
Contributor

0xCaso commented Feb 9, 2023

Hi @MuhammedIrfan, thanks for the delivery. Someone of the team will look into it soon.

By the way, could you please remove the Milestone 1 delivery file from this pull request?

@MuhammedIrfan MuhammedIrfan marked this pull request as ready for review February 13, 2023 16:31
@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

Hi @MuhammedIrfan, thanks for the delivery. Someone of the team will look into it soon.

By the way, could you please remove the Milestone 1 delivery file from this pull request?

I have removed it. Thank you @0xCaso.

@dsm-w3f dsm-w3f self-assigned this Feb 15, 2023
@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Feb 15, 2023

@MuhammedIrfan thank you for the milestone submission. Please see the evaluation document and provide proper answers and fixes. After that, let me know to continue with the evaluation.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Mar 3, 2023

@MuhammedIrfan this PR was marked as stale due lack of interaction for two weeks. Do you still intend to perform the fixes requested during the evaluation?

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@MuhammedIrfan this PR was marked as stale due lack of interaction for two weeks. Do you still intend to perform the fixes requested during the evaluation?

@dsm-w3f We have fixed couple of issues still need to fix couple more issues, I kindly request you to give us 1 more week to revert back with all issues fixed. Thank you.

@keeganquigley
Copy link
Copy Markdown
Contributor

Thanks @MuhammedIrfan please ping @dsm-w3f once complete.

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

Thanks @MuhammedIrfan please ping @dsm-w3f once complete.

Sure @keeganquigley

@MuhammedIrfan MuhammedIrfan marked this pull request as draft April 5, 2023 16:11
@github-actions github-actions bot added the stale label Apr 20, 2023
@keeganquigley
Copy link
Copy Markdown
Contributor

Hi @MuhammedIrfan I see you moved this to a draft. Are you still working on it?

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

Hi @MuhammedIrfan I see you moved this to a draft. Are you still working on it?

Hi @keeganquigley, Yes, Most of the parts are complete. We are waiting for M1 to complete.

@github-actions github-actions bot added to close and removed stale labels May 12, 2023
@MuhammedIrfan MuhammedIrfan marked this pull request as ready for review May 22, 2023 06:03
@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@dsm-w3f We have made some fixes and this PR is ready for review. Kindly review the milestone submission. Thank you.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented May 23, 2023

@MuhammedIrfan thank you for updating the milestone delivery. I updated the evaluation document. Please provide proper answers and fixes and let me know when I can continue this evaluation.

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@MuhammedIrfan thank you for updating the milestone delivery. I updated the evaluation document. Please provide proper answers and fixes and let me know when I can continue this evaluation.

@dsm-w3f Thank you for reviewing the delivery, We will fix the issues and revert back soon.

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@dsm-w3f We have fixed the issue and updated the delivery document. I request you to kindly re-evaluate the delivery. Thank you.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Jun 13, 2023

@MuhammedIrfan thank you for the improvements and fixes. I updated the evaluation document. I need a way to run the workflow that doesn't needs programming and a testing guide to check it. Could you provide it?

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@MuhammedIrfan thank you for the improvements and fixes. I updated the evaluation document. I need a way to run the workflow that doesn't needs programming and a testing guide to check it. Could you provide it?

@dsm-w3f Thank you for the evaluation. Workflow Macro is a rust macro and the core component of the workflow, The unit test along with workflow composer test infact would be covering the Workflow Macro, Our next milestone would be covering the utility of polkadot payout utility which would be covering the workflow macro that can be tested without programming guide.

The test for push notification might have failed due to missing FIREBASE_API_KEY and TEST_DEVICE_TOKEN Source Source, which can be generated using Link

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Jun 16, 2023

@MuhammedIrfan thank you for the answer. Ok to deliver the interface for workflow macro in the next milestone delivery. Besides that, I adjusted the env variables and the two tests are still failing. Could you please verify that? See details in the evaluation document.

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@MuhammedIrfan thank you for the answer. Ok to deliver the interface for workflow macro in the next milestone delivery. Besides that, I adjusted the env variables and the two tests are still failing. Could you please verify that? See details in the evaluation document.

@dsm-w3f We have prepared a video to help you navigate through the issue you are facing Link. Hope this helps you. Thank you.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Jun 19, 2023

@MuhammedIrfan thank you for providing the demo video. Now all tests are passing. See details in the evaluation document. The milestone delivery is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 30e3c52 into w3f:master Jun 19, 2023
@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@MuhammedIrfan thank you for providing the demo video. Now all tests are passing. See details in the evaluation document. The milestone delivery is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

Thank you @dsm-w3f

@MuhammedIrfan MuhammedIrfan deleted the aurras_mvp_2-m2 branch June 20, 2023 03:29
@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

@RouvenP As its been two weeks, Just wanted to check if you are facing any challenges with the invoice.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Jul 4, 2023

hi @MuhammedIrfan apologies for the delay! we just sent the payment

@MuhammedIrfan
Copy link
Copy Markdown
Contributor Author

hi @MuhammedIrfan apologies for the delay! we just sent the payment

No problem @RouvenP, Thank you. I acknowledge the receipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants