Skip to content

Tesseract dApp/Wallet Connection: milestone #2#659

Merged
alxs merged 2 commits intow3f:masterfrom
tesseract-one:master
Dec 29, 2022
Merged

Tesseract dApp/Wallet Connection: milestone #2#659
alxs merged 2 commits intow3f:masterfrom
tesseract-one:master

Conversation

@dileping
Copy link
Copy Markdown
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#508

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Dec 19, 2022

Thanks for the delivery @dileping. We'll look into it as soon as possible.

@dileping
Copy link
Copy Markdown
Contributor Author

@alxs thank you! Looking forward to your feedback. Working on the article meanwhile.

@alxs alxs self-assigned this Dec 21, 2022
@alxs
Copy link
Copy Markdown
Contributor

alxs commented Dec 22, 2022

Thanks a lot for the detailed walkthrough and overall clean delivery, it's appreciated.

I tried running the example app as described in the guide

image

and the build failed with the following output: build.txt. What do you think could be the issue?

@alxs alxs added the on hold label Dec 22, 2022
@alxs
Copy link
Copy Markdown
Contributor

alxs commented Dec 22, 2022

Tagging this on hold until we've signed the amendment.

Also, would you mind using the list of features for this milestone from your email in the deliverables table? That would make it much easier to verify that the functionality is implemented. Thank you.

@dileping
Copy link
Copy Markdown
Contributor Author

Hi @alxs! Thanks for starting the review.

As for the amendment - I think there is a misunderstanding. As the amendment is for another grant (SwiftAPI) and this grant is totally fine and doesn't need any amendment :)

As for the error you are getting, it's probably due to missing rust targets. They can be added the following way:

rustup target add aarch64-linux-android armv7-linux-androideabi i686-linux-android x86_64-linux-android

Please, check the Prerequisites section in the testing guide for more details.

@dileping
Copy link
Copy Markdown
Contributor Author

Just in case added one more item to the prerequisites list which I just encountered during migrating to a new Mac: you might need to add rust.pythonCommand=python3 to local.properties. In the guide I've also updated it and marked with UPDATE! marker so that no one misses it :)

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Dec 27, 2022

Ah sorry, of course - my bad :)

I was able to fix the errors by adding the new targets, thanks. When you're done with the article, could you please send it to grantsPR@web3.foundation with grants@web3.foundation in cc?

@alxs alxs removed the on hold label Dec 27, 2022
@dileping
Copy link
Copy Markdown
Contributor Author

@alxs, thank you! I'm looking forward to more of your feedback. Glad that the targets suggestion worked for you.

As for the article, I just went ahead and sent it to the addresses you gave me.

@alxs
Copy link
Copy Markdown
Contributor

alxs commented Dec 29, 2022

That is all from my side, I'm happy to let you know that the milestone has been accepted :) You can have a look at my evaluation notes here. Thanks for the clean and thoroughly explained delivery!

I'll notify the operations team to pay out your invoice. As usual, please allow for up to 14 days for processing.

@alxs alxs merged commit 3828ed6 into w3f:master Dec 29, 2022
@dileping
Copy link
Copy Markdown
Contributor Author

dileping commented Jan 3, 2023

@alxs, thanks a lot for the fast review! Moving to the last milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants