Create escrow-pallet_2_3_keeganquigley.md#598
Merged
Noc2 merged 1 commit intow3f:masterfrom Oct 14, 2022
keeganquigley:master
Merged
Create escrow-pallet_2_3_keeganquigley.md#598Noc2 merged 1 commit intow3f:masterfrom keeganquigley:master
Noc2 merged 1 commit intow3f:masterfrom
keeganquigley:master
Conversation
5 tasks
Noc2
approved these changes
Oct 14, 2022
Contributor
Noc2
left a comment
Noc2
left a comment
There was a problem hiding this comment.
Looks good. I would have personally waited with the approval until they fixed the benchmark test, but they already fixed it anyway. So, I'm going to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery: #574
Application: w3f/Grants-Program#1094