Skip to content

Conversation

@daywednes
Copy link
Contributor

  • Massbit Route milestone 2

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#985

* Massbit Route milestone 2
@keeganquigley
Copy link
Contributor

Hi @daywednes thanks for your delivery. We have a bit of a backlog with evaluations currently but someone will take a look at this shortly. Thanks for your patience!

@daywednes
Copy link
Contributor Author

Thank you. Looking forward to it!!!

@dsm-w3f dsm-w3f self-assigned this Oct 20, 2022
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 24, 2022

@daywednes thank you for the milestone submission and my apologies for the late response. Please see the evaluation document and provide proper answers and fixes. The main problems were with the testing guides, which prevented me to perform the tests for the milestone delivery. Regarding the code quality assessment, feel free to fix/improve what makes sense for you. After that, let me know to continue with the evaluation.

@hoanito
Copy link
Contributor

hoanito commented Oct 25, 2022

@dsm-w3f Thanks. I will look into the evaluation and let you know as soon as we have things adjusted

@hoanito
Copy link
Contributor

hoanito commented Nov 12, 2022

@dsm-w3f The bash script for creating the environment was missing some docker components, and it has been corrected. Feel free to ping me on Element if you have question during your evaluation.

Please note that the docker environment we submitted for this grant demonstrates features in application document, so some parts are bypassed (such as new account created will be verified without email confirmation, each new account will have 1000 KEI token for staking without accessing the faucet)

We also added documentation for the code and tests for Session and Stats

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Nov 22, 2022

@daywednes and @hoanito thank you for the improvements and help during this evaluation. The evaluation document was updated and the milestone is approved. I'll forward internally the invoice and the payment should occur within two weeks (could happen before). Great Job!

@dsm-w3f dsm-w3f merged commit f81e000 into w3f:master Nov 22, 2022
@daywednes
Copy link
Contributor Author

@dsm-w3f we submitted the invoice last week FYI.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Nov 28, 2022

Hi @daywednes, I already forwarded your invoice last week, it should be processed soon.

@daywednes
Copy link
Contributor Author

@dsm-w3f can you please check the status? thank you

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Dec 5, 2022

@daywednes my apologies for the delay. The payment should happen this week.

@daywednes
Copy link
Contributor Author

@dsm-w3f friendly remind again as i have not received it. Cheers

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Dec 12, 2022

@fededubbi can you give an update about the status of the payment of this grant delivery?

@RouvenP
Copy link

RouvenP commented Dec 13, 2022

hi @daywednes we just transferred the payment - apologies for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants