-
Notifications
You must be signed in to change notification settings - Fork 581
Massbit Milestone 2 delivery #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Massbit Route milestone 2
|
Hi @daywednes thanks for your delivery. We have a bit of a backlog with evaluations currently but someone will take a look at this shortly. Thanks for your patience! |
|
Thank you. Looking forward to it!!! |
|
@daywednes thank you for the milestone submission and my apologies for the late response. Please see the evaluation document and provide proper answers and fixes. The main problems were with the testing guides, which prevented me to perform the tests for the milestone delivery. Regarding the code quality assessment, feel free to fix/improve what makes sense for you. After that, let me know to continue with the evaluation. |
|
@dsm-w3f Thanks. I will look into the evaluation and let you know as soon as we have things adjusted |
|
@dsm-w3f The bash script for creating the environment was missing some docker components, and it has been corrected. Feel free to ping me on Element if you have question during your evaluation. Please note that the docker environment we submitted for this grant demonstrates features in application document, so some parts are bypassed (such as new account created will be verified without email confirmation, each new account will have 1000 KEI token for staking without accessing the faucet) We also added documentation for the code and tests for Session and Stats |
|
@daywednes and @hoanito thank you for the improvements and help during this evaluation. The evaluation document was updated and the milestone is approved. I'll forward internally the invoice and the payment should occur within two weeks (could happen before). Great Job! |
|
@dsm-w3f we submitted the invoice last week FYI. |
|
Hi @daywednes, I already forwarded your invoice last week, it should be processed soon. |
|
@dsm-w3f can you please check the status? thank you |
|
@daywednes my apologies for the delay. The payment should happen this week. |
|
@dsm-w3f friendly remind again as i have not received it. Cheers |
|
@fededubbi can you give an update about the status of the payment of this grant delivery? |
|
hi @daywednes we just transferred the payment - apologies for the delay! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#985