Skip to content

Nolik Milestone 2#567

Merged
keeganquigley merged 2 commits intow3f:masterfrom
amrbz:master
Sep 29, 2022
Merged

Nolik Milestone 2#567
keeganquigley merged 2 commits intow3f:masterfrom
amrbz:master

Conversation

@amrbz
Copy link
Copy Markdown
Contributor

@amrbz amrbz commented Sep 12, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#759 < please fill this in with the PR number of your application.

@takahser
Copy link
Copy Markdown
Contributor

@amrbz thanks for your delivery! We currently have a rather large backlog to tackle with, so it might take a bit longer than usual until your delivery is evaluated. Nevertheless, we're going to take a look at it as soon as we can.

@amrbz
Copy link
Copy Markdown
Contributor Author

amrbz commented Sep 13, 2022

@takahser Sure, no problem. Thank you very much!

@keeganquigley
Copy link
Copy Markdown
Contributor

Hi @amrbz I have started the process of evaluating your milestone. Please give me some time to fully understand your project and I will reach out to you with any questions that I may have. Thanks!

@keeganquigley keeganquigley self-assigned this Sep 23, 2022
@amrbz
Copy link
Copy Markdown
Contributor Author

amrbz commented Sep 24, 2022

Hi @keeganquigley Great, I hope this one will be easy for you. Thanks!

@andredif
Copy link
Copy Markdown
Contributor

Hi @amrbz , I'm also currently reviewing your milestone. While I successfully managed to generate wallet and account, compose message and send it, it seems that in the documentation the command needed to read messages is missing, only valid arguments are shown. Can you please check it and fix it?Thank you very much.

@amrbz
Copy link
Copy Markdown
Contributor Author

amrbz commented Sep 26, 2022

Hi @andredif
Yeah, for some reason missed this one. My bad. I've updated the README file.
The required command would be:
cargo run -- get messages -a alice

@keeganquigley
Copy link
Copy Markdown
Contributor

Thanks for the evaluation @andredif and thanks for your patience @amrbz while I tested everything out and ran all the tests. The CLI app works great! Excellent test coverage as well. Docker setup was easy. I'm good to go ahead and pass this milestone!

keeganquigley added a commit that referenced this pull request Sep 29, 2022
@keeganquigley keeganquigley merged commit b12d4f2 into w3f:master Sep 29, 2022
@amrbz
Copy link
Copy Markdown
Contributor Author

amrbz commented Sep 30, 2022

Thank you @andredif @keeganquigley @takahser for your work and for the great news! You made my day ) It was a pleasure to work with you on this project. I'm currently writing an article that describes in details the idea behind the protocol and intend to publish it during the next week. I've applied to Polkadot DevCamp and going to join Substrate Builders program as well. So, I hope that we will have a chance to work closely in future. Thank you very much, guys )

@keeganquigley
Copy link
Copy Markdown
Contributor

@andredif You're very welcome! I will share the news with the team. Your invoice has been forwarded for payment.

@amrbz
Copy link
Copy Markdown
Contributor Author

amrbz commented Oct 12, 2022

Hi guys,
I've published the article:
https://medium.com/@amrbz/decentralising-messaging-f4cc73d4d9b7

@semuelle semuelle changed the title Nolik Milestone #2 Nolik Milestone 2 Oct 12, 2022
@alxs alxs mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants